isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

loginDialog: Do not expand "Not listed" button

Browse Source 
Visually the button is just an interactive label, so having the
interactive area extend to the empty space next to the label
is surprising.

Instead, left-align the whole button rather than just the label
inside, so the clickable area corresponds to the visible one.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/1046
This commit is contained in:
Florian Müllner 2020-02-25 18:15:49 +01:00 committed by Florian Müllner
parent d66f5ab3c6
commit 19fc7c4d31
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
js/gdm/loginDialog.js
View File

@ -456,7 +456,6 @@ var LoginDialog = GObject.registerClass({
let notListedLabel = new St.Label({ let notListedLabel = new St.Label({
text: _("Not listed?"), text: _("Not listed?"),
style_class: 'login-dialog-not-listed-label', style_class: 'login-dialog-not-listed-label',
x_align: Clutter.ActorAlign.START,
}); });
this._notListedButton = new St.Button({ this._notListedButton = new St.Button({
style_class: 'login-dialog-not-listed-button', style_class: 'login-dialog-not-listed-button',
@ -464,6 +463,7 @@ var LoginDialog = GObject.registerClass({
can_focus: true, can_focus: true,
child: notListedLabel, child: notListedLabel,
reactive: true, reactive: true,
x_align: Clutter.ActorAlign.START,
}); });
this._notListedButton.connect('clicked', this._hideUserListAskForUsernameAndBeginVerification.bind(this)); this._notListedButton.connect('clicked', this._hideUserListAskForUsernameAndBeginVerification.bind(this));