isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

messageTray: Clean up variable names

Browse Source 
Variable names like "sourceNotificationStackDoneShowing" are too
long, and too undescriptive: this one points to a source, not a
notification stack that has been done showing.
This commit is contained in:
Jasper St. Pierre 2013-01-02 07:56:07 -05:00
parent 54a9592e19
commit 176a73f4e9
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
js/ui/messageTray.js
View File

@ -2768,17 +2768,14 @@ const MessageTray = new Lang.Class({
this._summaryBoxPointerState = State.HIDDEN; this._summaryBoxPointerState = State.HIDDEN;
this._summaryBoxPointer.bin.child = null; this._summaryBoxPointer.bin.child = null;
let sourceNotificationStackDoneShowing = null;
if (doneShowingNotificationStack) { if (doneShowingNotificationStack) {
this._summaryBoxPointerItem.doneShowingNotificationStack(); let source = this._summaryBoxPointerItem.source;
sourceNotificationStackDoneShowing = this._summaryBoxPointerItem.source;
}
this._summaryBoxPointerItem.doneShowingNotificationStack();
this._summaryBoxPointerItem = null; this._summaryBoxPointerItem = null;
if (sourceNotificationStackDoneShowing) { if (source.isTransient && !this._reNotifyAfterHideNotification)
if (sourceNotificationStackDoneShowing.isTransient && !this._reNotifyAfterHideNotification) source.destroy(NotificationDestroyedReason.EXPIRED);
sourceNotificationStackDoneShowing.destroy(NotificationDestroyedReason.EXPIRED);
if (this._reNotifyAfterHideNotification) { if (this._reNotifyAfterHideNotification) {
this._onNotify(this._reNotifyAfterHideNotification.source, this._reNotifyAfterHideNotification); this._onNotify(this._reNotifyAfterHideNotification.source, this._reNotifyAfterHideNotification);
this._reNotifyAfterHideNotification = null; this._reNotifyAfterHideNotification = null;