From 1309b64c336ed38d7cd05821b02256f72ba0bcc8 Mon Sep 17 00:00:00 2001 From: Adel Gadllah Date: Sun, 12 Jun 2011 14:03:18 +0200 Subject: [PATCH] shell-window-tracker: Fix signal handler leak Disconnect the on_wm_class_changed handler when removing a window in disassociate_window(). https://bugzilla.gnome.org/show_bug.cgi?id=652388 --- src/shell-window-tracker.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/shell-window-tracker.c b/src/shell-window-tracker.c index 981124594..4b7b2d4eb 100644 --- a/src/shell-window-tracker.c +++ b/src/shell-window-tracker.c @@ -487,7 +487,10 @@ disassociate_window (ShellWindowTracker *self, g_hash_table_remove (self->window_to_app, window); if (shell_window_tracker_is_window_interesting (window)) + { _shell_app_remove_window (app, window); + g_signal_handlers_disconnect_by_func (window, G_CALLBACK(on_wm_class_changed), self); + } g_signal_emit (self, signals[TRACKED_WINDOWS_CHANGED], 0);