From 11d8640ba6e5cb3276d915a316f00f13a3568b8a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Fri, 17 Jan 2014 08:25:49 -0500 Subject: [PATCH] workspacesView: Fix activating empty workspaces By default, gesture actions no longer wait for the dnd threshold to be reached before triggering, which breaks our mixing of click- and pan actions. Fix this by only panning after reaching the threshold and letting the click action go through if the pan is cancelled. https://bugzilla.gnome.org/show_bug.cgi?id=722417 --- js/ui/workspacesView.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/js/ui/workspacesView.js b/js/ui/workspacesView.js index 1d0982b79..59e968275 100644 --- a/js/ui/workspacesView.js +++ b/js/ui/workspacesView.js @@ -405,7 +405,7 @@ const WorkspacesDisplay = new Lang.Class({ Main.overview.addAction(clickAction); this.actor.bind_property('mapped', clickAction, 'enabled', GObject.BindingFlags.SYNC_CREATE); - let panAction = new Clutter.PanAction(); + let panAction = new Clutter.PanAction({ threshold_trigger_edge: Clutter.GestureTriggerEdge.AFTER }); panAction.connect('pan', Lang.bind(this, this._onPan)); panAction.connect('gesture-begin', Lang.bind(this, function() { for (let i = 0; i < this._workspacesViews.length; i++) @@ -413,7 +413,6 @@ const WorkspacesDisplay = new Lang.Class({ return true; })); panAction.connect('gesture-cancel', Lang.bind(this, function() { - clickAction.release(); for (let i = 0; i < this._workspacesViews.length; i++) this._workspacesViews[i].endSwipeScroll(); }));