isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

extensionPrefs: Trick xgettext into accepting odd number of backticks

Browse Source 
Xgettext learned about template strings now, which is good. However
it's still buggy, so instead of the "classic" xgettext issue with
backticks, we now have exciting new issues to find work-arounds for.

One issue is that it doesn't detect backticks inside string constants
as regular characters, so having an odd number of backticks throws off
its regex.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/792
This commit is contained in:
Florian Müllner 2019-10-29 14:01:07 +01:00 committed by Florian Müllner
parent fa1b7a9ef5
commit 10b2083d3e
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
js/extensionPrefs/main.js
View File

@ -159,14 +159,14 @@ var Application = GObject.registerClass({
// markdown for pasting in gitlab issues // markdown for pasting in gitlab issues
let lines = [ let lines = [
`The settings of extension ${row.uuid} had an error:`, `The settings of extension ${row.uuid} had an error:`,
'```', '```', // '`' (xgettext throws up on odd number of backticks)
`${exc}`, `${exc}`,
'```', '```', // '`'
'', '',
'Stack trace:', 'Stack trace:',
'```', '```', // '`'
exc.stack.replace(/\n$/, ''), // stack without trailing newline exc.stack.replace(/\n$/, ''), // stack without trailing newline
'```', '```', // '`'
'' ''
]; ];
clipboard.set_text(lines.join('\n'), -1); clipboard.set_text(lines.join('\n'), -1);