isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

authPrompt: Only spin on password entries

Browse Source 
Spinning while typing the password is a bit off-putting, and
inconsistent with how regular authentication behaves.

Only spin the spinner after typing the password.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/922
This commit is contained in:
Georges Basile Stavracas Neto 2020-02-11 10:33:02 -03:00 committed by Florian Müllner
parent 077a1d2309
commit 0f34cbb658
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
js/gdm/authPrompt.js
View File

@ -157,8 +157,9 @@ var AuthPrompt = GObject.registerClass({
});
entry.clutter_text.connect('activate', () => {
let shouldSpin = entry === this._passwordEntry;
if (entry.reactive)
this._activateNext();
this._activateNext(shouldSpin);
});
});
@ -177,9 +178,12 @@ var AuthPrompt = GObject.registerClass({
this._defaultButtonWell.add_child(this._spinner);
}
_activateNext() {
_activateNext(shouldSpin) {
this.updateSensitivity(false);
this.startSpinning();
if (shouldSpin)
this.startSpinning();
if (this._queryingService)
this._userVerifier.answerQuery(this._queryingService, this._entry.text);
else

1
js/gdm/loginDialog.js
View File

@ -928,7 +928,6 @@ var LoginDialog = GObject.registerClass({
let answer = this._authPrompt.getAnswer();
this._user = this._userManager.get_user(answer);
this._authPrompt.clear();
this._authPrompt.startSpinning();
this._authPrompt.begin({ userName: answer });
this._updateCancelButton();
});