From 0d2eb76cee15adf2fb8307eaab42529fbab21786 Mon Sep 17 00:00:00 2001 From: Giovanni Campagna Date: Sat, 26 Feb 2011 19:21:10 +0100 Subject: [PATCH] Ensure that all signatures are defined in DBus interfaces The DBus JS binding will complain if the signature of a method or of a signal is undefined, so we need to define it even if it is an empty string, and we need to use the correct property name for signals. https://bugzilla.gnome.org/show_bug.cgi?id=643374 --- js/misc/gnomeSession.js | 3 ++- js/ui/endSessionDialog.js | 2 +- js/ui/status/power.js | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/js/misc/gnomeSession.js b/js/misc/gnomeSession.js index ef4ef848d..ce4e7e9d3 100644 --- a/js/misc/gnomeSession.js +++ b/js/misc/gnomeSession.js @@ -7,7 +7,8 @@ const Signals = imports.signals; const PresenceIface = { name: 'org.gnome.SessionManager.Presence', methods: [{ name: 'SetStatus', - inSignature: 'u' }], + inSignature: 'u', + outSignature: '' }], properties: [{ name: 'status', signature: 'u', access: 'readwrite' }], diff --git a/js/ui/endSessionDialog.js b/js/ui/endSessionDialog.js index be64427e0..08c5705c9 100644 --- a/js/ui/endSessionDialog.js +++ b/js/ui/endSessionDialog.js @@ -54,7 +54,7 @@ const EndSessionDialogIface = { } ], signals: [{ name: 'Canceled', - outSignature: '', + inSignature: '', }], properties: [] }; diff --git a/js/ui/status/power.js b/js/ui/status/power.js index 263d48e3d..94469334d 100644 --- a/js/ui/status/power.js +++ b/js/ui/status/power.js @@ -49,7 +49,7 @@ const PowerManagerInterface = { { name: 'GetPrimaryDevice', inSignature: '', outSignature: '(susbut)' }, ], signals: [ - { name: 'Changed', outSignature: '' }, + { name: 'Changed', inSignature: '' }, ], properties: [ { name: 'Icon', signature: 's', access: 'read' },