From 0c72d1fcbdeba3001fbdab87311b13acebbf6509 Mon Sep 17 00:00:00 2001 From: Rui Matos Date: Thu, 22 Oct 2015 18:12:28 +0200 Subject: [PATCH] ActivitiesButton: fix overview being toggled while still animating Adds the missing checks for whether we should toggle the overview, on button and key release. https://bugzilla.gnome.org/show_bug.cgi?id=756925 --- js/ui/panel.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/js/ui/panel.js b/js/ui/panel.js index 3127db03f..aad466df7 100644 --- a/js/ui/panel.js +++ b/js/ui/panel.js @@ -459,7 +459,8 @@ const ActivitiesButton = new Lang.Class({ if (event.type() == Clutter.EventType.TOUCH_END || event.type() == Clutter.EventType.BUTTON_RELEASE) - Main.overview.toggle(); + if (Main.overview.shouldToggleByCornerOrButton()) + Main.overview.toggle(); return Clutter.EVENT_PROPAGATE; }, @@ -467,7 +468,8 @@ const ActivitiesButton = new Lang.Class({ _onKeyRelease: function(actor, event) { let symbol = event.get_key_symbol(); if (symbol == Clutter.KEY_Return || symbol == Clutter.KEY_space) { - Main.overview.toggle(); + if (Main.overview.shouldToggleByCornerOrButton()) + Main.overview.toggle(); } return Clutter.EVENT_PROPAGATE; },