isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix details pane repositioning

Browse Source 
Two calls to _repositionDetails() were done too early,
before the visibility of the results pane had changed,
so they had no effect. Thus when a search was done while
a details pane was active, the pane with the results was
hidden by the details pane.

In addition to fixing this, move the two remaining calls to
the line after changing the results pane's visibility
to make it clearer why the calls are there.
This commit is contained in:
Siegfried-Angel Gevatter Pujals 2009-07-31 16:08:39 +02:00
parent f7fff83647
commit 0a1aac862f
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
js/ui/overlay.js
View File

@ -583,9 +583,9 @@ Dash.prototype = {
this._resultsAppsSection.display.show(); this._resultsAppsSection.display.show();
this._resultsPane.append(this._resultsAppsSection.actor, Big.BoxPackFlags.EXPAND); this._resultsPane.append(this._resultsAppsSection.actor, Big.BoxPackFlags.EXPAND);
this._resultsPane.show(); this._resultsPane.show();
this._repositionDetails();
this._moreAppsLink.setText("Less..."); this._moreAppsLink.setText("Less...");
this._repositionDetails();
this.emit('panes-displayed'); this.emit('panes-displayed');
}, },
@ -617,11 +617,10 @@ Dash.prototype = {
this._resultsDocsSection.display.show(); this._resultsDocsSection.display.show();
this._resultsPane.append(this._resultsDocsSection.actor, Big.BoxPackFlags.EXPAND); this._resultsPane.append(this._resultsDocsSection.actor, Big.BoxPackFlags.EXPAND);
this._resultsPane.show(); this._resultsPane.show();
this._repositionDetails();
this._moreDocsLink.setText("Less..."); this._moreDocsLink.setText("Less...");
this._repositionDetails();
this.emit('panes-displayed'); this.emit('panes-displayed');
}, },
@ -642,7 +641,6 @@ Dash.prototype = {
}, },
_setSearchMode: function() { _setSearchMode: function() {
this._repositionDetails();
if (this._resultsShowing()) if (this._resultsShowing())
return; return;
@ -656,17 +654,18 @@ Dash.prototype = {
this._resultsPane.append(this._resultsDocsSection.actor, Big.BoxPackFlags.EXPAND); this._resultsPane.append(this._resultsDocsSection.actor, Big.BoxPackFlags.EXPAND);
this._resultsPane.show(); this._resultsPane.show();
this._repositionDetails();
this.emit('panes-displayed'); this.emit('panes-displayed');
}, },
_unsetSearchMode: function() { _unsetSearchMode: function() {
this._repositionDetails();
if (this._moreDocsMode || this._moreAppsMode || !this._resultsShowing()) if (this._moreDocsMode || this._moreAppsMode || !this._resultsShowing())
return; return;
this._resultsPane.hide(); this._resultsPane.hide();
this._repositionDetails();
this._resultsPane.remove_actor(this._resultsAppsSection.actor); this._resultsPane.remove_actor(this._resultsAppsSection.actor);
this._resultsAppsSection.display.hide(); this._resultsAppsSection.display.hide();