isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[placesDisplay] Replace remaining Big.Boxes with St.Widgets

Browse Source 
While most of the code already is CSS stylable, the two-colum setup
is still done using Big.Box with hard coded spacings. Port those
remaining parts to St.Widget, so that all spacings can be adjusted
by the theme.

https://bugzilla.gnome.org/show_bug.cgi?id=610385
This commit is contained in:
Florian Müllner 2010-02-23 14:33:12 +01:00
parent ca2a11c57d
commit 095e15fc11
2 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
data/theme/gnome-shell.css
View File

@ -518,6 +518,10 @@ StTooltip {
/* Places */ /* Places */
.places-section {
spacing-columns: 4px;
}
.places-item-box { .places-item-box {
spacing: 4px; spacing: 4px;
} }

26
js/ui/placeDisplay.js
View File

@ -1,6 +1,5 @@
/* -*- mode: js2; js2-basic-offset: 4; indent-tabs-mode: nil -*- */ /* -*- mode: js2; js2-basic-offset: 4; indent-tabs-mode: nil -*- */
const Big = imports.gi.Big;
const Clutter = imports.gi.Clutter; const Clutter = imports.gi.Clutter;
const Pango = imports.gi.Pango; const Pango = imports.gi.Pango;
const GLib = imports.gi.GLib; const GLib = imports.gi.GLib;
@ -516,28 +515,25 @@ DashPlaceDisplay.prototype = {
// look better in that there would be an even number of items left+right, // look better in that there would be an even number of items left+right,
// but it seems like we want some sort of differentiation between actions // but it seems like we want some sort of differentiation between actions
// like "Connect to server..." and regular folders // like "Connect to server..." and regular folders
this.actor = new Big.Box({ orientation: Big.BoxOrientation.HORIZONTAL, this.actor = new St.Table({ style_class: 'places-section',
spacing: 4 }); homogeneous: true });
this._leftBox = new Big.Box({ orientation: Big.BoxOrientation.VERTICAL });
this.actor.append(this._leftBox, Big.BoxPackFlags.EXPAND);
this._rightBox = new Big.Box({ orientation: Big.BoxOrientation.VERTICAL });
this.actor.append(this._rightBox, Big.BoxPackFlags.EXPAND);
// Subdivide left into actions and devices
this._actionsBox = new St.BoxLayout({ style_class: 'places-actions', this._actionsBox = new St.BoxLayout({ style_class: 'places-actions',
vertical: true }); vertical: true });
this._devBox = new St.BoxLayout({ style_class: 'places-actions', this._devBox = new St.BoxLayout({ style_class: 'places-actions',
name: 'placesDevices', name: 'placesDevices',
vertical: true }); vertical: true });
this._dirsBox = new St.BoxLayout({ style_class: 'places-actions', this._dirsBox = new St.BoxLayout({ style_class: 'places-actions',
vertical: true }); vertical: true });
this._leftBox.append(this._actionsBox, Big.BoxPackFlags.NONE); // Subdivide left into actions and devices
this._leftBox.append(this._devBox, Big.BoxPackFlags.NONE); this.actor.add(this._actionsBox, { row: 0, col: 0 });
this.actor.add(this._devBox, { row: 1, col: 0 });
this._rightBox.append(this._dirsBox, Big.BoxPackFlags.NONE); // Bookmarks span the entire right
this.actor.add(this._dirsBox, { row: 0, col: 1, row_span: 2 });
Main.placesManager.connect('defaults-updated', Lang.bind(this, this._updateDefaults)); Main.placesManager.connect('defaults-updated', Lang.bind(this, this._updateDefaults));
Main.placesManager.connect('bookmarks-updated', Lang.bind(this, this._updateBookmarks)); Main.placesManager.connect('bookmarks-updated', Lang.bind(this, this._updateBookmarks));