isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

extensionSystem: Make the init function optional

Browse Source 
A large amount of extensions have something like this in them:

    function init() {}

Since we have encouraged extension authors to try and not make any
changes in init, it feels weird and strange to have to create an
initialization function that does nothing. From now on, don't require
it.

https://bugzilla.gnome.org/show_bug.cgi?id=677586
This commit is contained in:
Jasper St. Pierre 2012-06-04 18:43:52 -04:00
parent 11278a0814
commit 0805d7a35f
1 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
js/ui/extensionSystem.js
View File

@ -190,17 +190,14 @@ function initExtension(uuid) {
return; return;
} }
if (!extensionModule.init) { if (extensionModule.init) {
logExtensionError(uuid, 'missing \'init\' function');
return;
}
try { try {
extensionState = extensionModule.init(extension); extensionState = extensionModule.init(extension);
} catch (e) { } catch (e) {
logExtensionError(uuid, 'Failed to evaluate init function:' + e); logExtensionError(uuid, 'Failed to evaluate init function:' + e);
return; return;
} }
}
if (!extensionState) if (!extensionState)
extensionState = extensionModule; extensionState = extensionModule;