From 056f5e5100bed08043389146b03be84a60cab876 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20Dre=C3=9Fler?= Date: Thu, 23 Jan 2020 22:37:06 +0100 Subject: [PATCH] shellEntry: Make signal id variable private Signal connection IDs should be private variables, so make this one private. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/952 --- js/ui/shellEntry.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/js/ui/shellEntry.js b/js/ui/shellEntry.js index c6e35fa83..77e3a185b 100644 --- a/js/ui/shellEntry.js +++ b/js/ui/shellEntry.js @@ -165,19 +165,19 @@ class CapsLockWarning extends St.Label { this.connect('notify::mapped', () => { if (this.is_mapped()) { - this.stateChangedId = this._keymap.connect('state-changed', + this._stateChangedId = this._keymap.connect('state-changed', this._updateCapsLockWarningOpacity.bind(this)); } else { - this._keymap.disconnect(this.stateChangedId); - this.stateChangedId = 0; + this._keymap.disconnect(this._stateChangedId); + this._stateChangedId = 0; } this._updateCapsLockWarningOpacity(); }); this.connect('destroy', () => { - if (this.stateChangedId > 0) - this._keymap.disconnect(this.stateChangedId); + if (this._stateChangedId > 0) + this._keymap.disconnect(this._stateChangedId); }); this.clutter_text.ellipsize = Pango.EllipsizeMode.NONE;