appIconMenu: Disable sourceActor key events

Enter/space are already taken over by the app icon to activate the
app, and arrow keys interfere with keyboard navigation where icons
are arranged in a grid (namely the app picker).

Also as app icons only create the menu when it is first needed, the
shortcuts only starts to work once a menu has been opened, which is
rather inconsistent and confusing.

It is better to simply disable the key handling altogether for the
app icon menu.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/98
This commit is contained in:
Florian Müllner 2018-09-11 16:06:09 +02:00
parent 2d791a51c0
commit 035dfe2a19

View File

@ -1854,6 +1854,11 @@ var AppIconMenu = new Lang.Class({
Main.uiGroup.add_actor(this.actor);
},
// disable parent's handler
_onKeyPress(actor, event) {
return Clutter.EVENT_PROPAGATE;
},
_redisplay() {
this.removeAll();