isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lookingGlass: Handle unprintable object

Browse Source 
We currently throw an error when encountering a result that cannot
be represented as string, with the prompt appearing somewhat stuck
(the input cannot be committed).

Showing a lame fallback instead at least avoids that issue. When
the object has a typeof 'object' but is not an instanceof Object,
we are likely dealing with an ES module, and can show a slightly
less lame fallback.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2842>
This commit is contained in:
Florian Müllner 2023-07-13 00:25:43 +02:00 committed by Marge Bot
parent 21e4cb142d
commit 03025d7cff
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
js/ui/lookingGlass.js
View File

@ -268,6 +268,11 @@ function objectToString(o) {
if (typeof o == typeof objectToString) { if (typeof o == typeof objectToString) {
// special case this since the default is way, way too verbose // special case this since the default is way, way too verbose
return '<js function>'; return '<js function>';
} else if (o && o.toString === undefined) {
// eeks, something unprintable. we'll have to guess, probably a module
return typeof o === 'object' && !(o instanceof Object)
? '<module>'
: '<unknown>';
} else { } else {
return `${o}`; return `${o}`;
} }