isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

objectManager: correct other invalid index code in onNameVanished

Browse Source 
The object manager tries to synthesize interface removal
events if the bus name of a remote object drops off the bus.

The code had bad typos in it, though: it reuses the `i`
index variable in its inner loop, where it should be using
the `j` index variable.

This commit corrects the i/j confusion.
This commit is contained in:
Ray Strode 2018-08-31 12:48:00 -04:00 committed by Florian Müllner
parent dc5df5c4c9
commit 025f6eb68e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/misc/objectManager.js
View File

@ -240,8 +240,8 @@ var ObjectManager = new Lang.Class({
let object = this._objects[objectPath]; let object = this._objects[objectPath];
let interfaceNames = Object.keys(object); let interfaceNames = Object.keys(object);
for (let j = 0; i < interfaceNames.length; i++) { for (let j = 0; j < interfaceNames.length; j++) {
let interfaceName = interfaceNames[i]; let interfaceName = interfaceNames[j];
if (object[interfaceName]) if (object[interfaceName])
this._removeInterface(objectPath, interfaceName); this._removeInterface(objectPath, interfaceName);