From 018e3bc35f228aa1389cdc0dcc9c3dcb2e28c3ef Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Tue, 5 Apr 2011 21:53:07 +0200 Subject: [PATCH] search-tab: Don't handle clicks on inactive icon The icon set as secondary icon of the search entry depends on whether a search is active or not - clicking the icon should reset the entry only in the former case. This is implemented by connecting/disconnecting the 'secondary-icon-clicked' signal when updating the icon, but an additional signal connection was left-over when refactoring the search entry, resulting in clicks on the inactive icon removing the hint text. Fix by removing the stray signal connection. https://bugzilla.gnome.org/show_bug.cgi?id=646855 --- js/ui/viewSelector.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/js/ui/viewSelector.js b/js/ui/viewSelector.js index 87e3e8a8e..00ec8a408 100644 --- a/js/ui/viewSelector.js +++ b/js/ui/viewSelector.js @@ -152,10 +152,6 @@ SearchTab.prototype = { return true; })); - this._entry.connect('secondary-icon-clicked', Lang.bind(this, - function() { - this._reset(); - })); this._entry.connect('notify::mapped', Lang.bind(this, this._onMapped)); global.stage.connect('notify::key-focus', Lang.bind(this, this._updateCursorVisibility));