![Jonas Ådahl](/assets/img/avatar_default.png)
Make sure that if we wiggle a scan-out capable surface a bit, it won't scan out if it's not exactly in the right position. Do this by first making the window not fullscreen, then moving it back and forth, verifying the correct scanout state for each presented frame. This test addition reproduces the issue described in https://gitlab.gnome.org/GNOME/mutter/-/issues/2387. Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2624>
317 lines
10 KiB
C
317 lines
10 KiB
C
/*
|
|
* Copyright (C) 2021 Red Hat Inc.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation; either version 2 of the
|
|
* License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
|
|
* 02111-1307, USA.
|
|
*
|
|
*/
|
|
|
|
#include "config.h"
|
|
|
|
#include <xf86drmMode.h>
|
|
|
|
#include "backends/native/meta-backend-native-private.h"
|
|
#include "backends/native/meta-crtc-kms.h"
|
|
#include "backends/native/meta-device-pool.h"
|
|
#include "backends/native/meta-drm-buffer.h"
|
|
#include "backends/native/meta-onscreen-native.h"
|
|
#include "backends/native/meta-kms.h"
|
|
#include "backends/native/meta-kms-device.h"
|
|
#include "core/display-private.h"
|
|
#include "meta/meta-backend.h"
|
|
#include "meta-test/meta-context-test.h"
|
|
#include "tests/meta-test-utils.h"
|
|
#include "tests/meta-wayland-test-driver.h"
|
|
#include "tests/meta-wayland-test-utils.h"
|
|
|
|
typedef struct
|
|
{
|
|
int number_of_frames_left;
|
|
GMainLoop *loop;
|
|
|
|
struct {
|
|
int n_paints;
|
|
uint32_t fb_id;
|
|
} scanout;
|
|
|
|
gboolean wait_for_scanout;
|
|
} KmsRenderingTest;
|
|
|
|
static MetaContext *test_context;
|
|
|
|
static void
|
|
on_after_update (ClutterStage *stage,
|
|
ClutterStageView *stage_view,
|
|
KmsRenderingTest *test)
|
|
{
|
|
test->number_of_frames_left--;
|
|
if (test->number_of_frames_left == 0)
|
|
g_main_loop_quit (test->loop);
|
|
else
|
|
clutter_actor_queue_redraw (CLUTTER_ACTOR (stage));
|
|
}
|
|
|
|
static void
|
|
meta_test_kms_render_basic (void)
|
|
{
|
|
MetaBackend *backend = meta_context_get_backend (test_context);
|
|
ClutterActor *stage = meta_backend_get_stage (backend);
|
|
KmsRenderingTest test;
|
|
gulong handler_id;
|
|
|
|
test = (KmsRenderingTest) {
|
|
.number_of_frames_left = 10,
|
|
.loop = g_main_loop_new (NULL, FALSE),
|
|
};
|
|
handler_id = g_signal_connect (stage, "after-update",
|
|
G_CALLBACK (on_after_update), &test);
|
|
|
|
clutter_actor_queue_redraw (CLUTTER_ACTOR (stage));
|
|
g_main_loop_run (test.loop);
|
|
g_main_loop_unref (test.loop);
|
|
|
|
g_assert_cmpint (test.number_of_frames_left, ==, 0);
|
|
|
|
g_signal_handler_disconnect (stage, handler_id);
|
|
}
|
|
|
|
static void
|
|
on_scanout_before_update (ClutterStage *stage,
|
|
ClutterStageView *stage_view,
|
|
KmsRenderingTest *test)
|
|
{
|
|
test->scanout.n_paints = 0;
|
|
test->scanout.fb_id = 0;
|
|
}
|
|
|
|
static void
|
|
on_scanout_before_paint (ClutterStage *stage,
|
|
ClutterStageView *stage_view,
|
|
KmsRenderingTest *test)
|
|
{
|
|
CoglScanout *scanout;
|
|
MetaDrmBuffer *buffer;
|
|
|
|
scanout = clutter_stage_view_peek_scanout (stage_view);
|
|
if (!scanout)
|
|
return;
|
|
|
|
g_assert_true (META_IS_DRM_BUFFER (scanout));
|
|
buffer = META_DRM_BUFFER (scanout);
|
|
test->scanout.fb_id = meta_drm_buffer_get_fb_id (buffer);
|
|
g_assert_cmpuint (test->scanout.fb_id, >, 0);
|
|
}
|
|
|
|
static void
|
|
on_scanout_paint_view (ClutterStage *stage,
|
|
ClutterStageView *stage_view,
|
|
KmsRenderingTest *test)
|
|
{
|
|
test->scanout.n_paints++;
|
|
}
|
|
|
|
static void
|
|
on_scanout_presented (ClutterStage *stage,
|
|
ClutterStageView *stage_view,
|
|
ClutterFrameInfo *frame_info,
|
|
KmsRenderingTest *test)
|
|
{
|
|
MetaBackend *backend = meta_context_get_backend (test_context);
|
|
MetaBackendNative *backend_native = META_BACKEND_NATIVE (backend);
|
|
MetaDevicePool *device_pool;
|
|
CoglFramebuffer *fb;
|
|
MetaCrtc *crtc;
|
|
MetaKmsCrtc *kms_crtc;
|
|
MetaKmsDevice *kms_device;
|
|
MetaDeviceFile *device_file;
|
|
GError *error = NULL;
|
|
drmModeCrtc *drm_crtc;
|
|
|
|
if (test->scanout.n_paints > 0)
|
|
return;
|
|
|
|
if (test->wait_for_scanout && test->scanout.fb_id == 0)
|
|
return;
|
|
|
|
device_pool = meta_backend_native_get_device_pool (backend_native);
|
|
|
|
fb = clutter_stage_view_get_onscreen (stage_view);
|
|
crtc = meta_onscreen_native_get_crtc (META_ONSCREEN_NATIVE (fb));
|
|
kms_crtc = meta_crtc_kms_get_kms_crtc (META_CRTC_KMS (crtc));
|
|
kms_device = meta_kms_crtc_get_device (kms_crtc);
|
|
|
|
device_file = meta_device_pool_open (device_pool,
|
|
meta_kms_device_get_path (kms_device),
|
|
META_DEVICE_FILE_FLAG_TAKE_CONTROL,
|
|
&error);
|
|
if (!device_file)
|
|
g_error ("Failed to open KMS device: %s", error->message);
|
|
|
|
drm_crtc = drmModeGetCrtc (meta_device_file_get_fd (device_file),
|
|
meta_kms_crtc_get_id (kms_crtc));
|
|
g_assert_nonnull (drm_crtc);
|
|
if (test->scanout.fb_id == 0)
|
|
g_assert_cmpuint (drm_crtc->buffer_id, !=, test->scanout.fb_id);
|
|
else
|
|
g_assert_cmpuint (drm_crtc->buffer_id, ==, test->scanout.fb_id);
|
|
drmModeFreeCrtc (drm_crtc);
|
|
|
|
meta_device_file_release (device_file);
|
|
|
|
g_main_loop_quit (test->loop);
|
|
}
|
|
|
|
typedef enum
|
|
{
|
|
SCANOUT_WINDOW_STATE_NONE,
|
|
SCANOUT_WINDOW_STATE_FULLSCREEN,
|
|
} ScanoutWindowState;
|
|
|
|
static void
|
|
meta_test_kms_render_client_scanout (void)
|
|
{
|
|
MetaBackend *backend = meta_context_get_backend (test_context);
|
|
MetaWaylandCompositor *wayland_compositor =
|
|
meta_context_get_wayland_compositor (test_context);
|
|
ClutterStage *stage = CLUTTER_STAGE (meta_backend_get_stage (backend));
|
|
MetaKms *kms = meta_backend_native_get_kms (META_BACKEND_NATIVE (backend));
|
|
MetaKmsDevice *kms_device = meta_kms_get_devices (kms)->data;
|
|
KmsRenderingTest test;
|
|
MetaWaylandTestClient *wayland_test_client;
|
|
g_autoptr (MetaWaylandTestDriver) test_driver = NULL;
|
|
gulong before_update_handler_id;
|
|
gulong before_paint_handler_id;
|
|
gulong paint_view_handler_id;
|
|
gulong presented_handler_id;
|
|
MetaWindow *window;
|
|
MetaRectangle view_rect;
|
|
MetaRectangle buffer_rect;
|
|
|
|
test_driver = meta_wayland_test_driver_new (wayland_compositor);
|
|
meta_wayland_test_driver_set_property (test_driver,
|
|
"gpu-path",
|
|
meta_kms_device_get_path (kms_device));
|
|
|
|
wayland_test_client =
|
|
meta_wayland_test_client_new ("dma-buf-scanout");
|
|
g_assert_nonnull (wayland_test_client);
|
|
|
|
test = (KmsRenderingTest) {
|
|
.loop = g_main_loop_new (NULL, FALSE),
|
|
.wait_for_scanout = TRUE,
|
|
};
|
|
|
|
g_assert_cmpuint (g_list_length (clutter_stage_peek_stage_views (stage)),
|
|
==,
|
|
1);
|
|
clutter_stage_view_get_layout (clutter_stage_peek_stage_views (stage)->data,
|
|
&view_rect);
|
|
|
|
paint_view_handler_id =
|
|
g_signal_connect (stage, "paint-view",
|
|
G_CALLBACK (on_scanout_paint_view), &test);
|
|
before_update_handler_id =
|
|
g_signal_connect (stage, "before-update",
|
|
G_CALLBACK (on_scanout_before_update), &test);
|
|
before_paint_handler_id =
|
|
g_signal_connect (stage, "before-paint",
|
|
G_CALLBACK (on_scanout_before_paint), &test);
|
|
presented_handler_id =
|
|
g_signal_connect (stage, "presented",
|
|
G_CALLBACK (on_scanout_presented), &test);
|
|
|
|
clutter_actor_queue_redraw (CLUTTER_ACTOR (stage));
|
|
g_main_loop_run (test.loop);
|
|
|
|
g_assert_cmpuint (test.scanout.fb_id, >, 0);
|
|
|
|
g_debug ("Unmake fullscreen");
|
|
window = meta_find_window_from_title (test_context, "dma-buf-scanout-test");
|
|
g_assert_true (meta_window_is_fullscreen (window));
|
|
meta_window_unmake_fullscreen (window);
|
|
|
|
g_debug ("Wait for fullscreen");
|
|
meta_wayland_test_driver_wait_for_sync_point (test_driver,
|
|
SCANOUT_WINDOW_STATE_NONE);
|
|
g_assert_false (meta_window_is_fullscreen (window));
|
|
|
|
g_debug ("Moving to 10, 10");
|
|
meta_window_move_frame (window, TRUE, 10, 10);
|
|
|
|
meta_window_get_buffer_rect (window, &buffer_rect);
|
|
g_assert_cmpint (buffer_rect.width, ==, view_rect.width);
|
|
g_assert_cmpint (buffer_rect.height, ==, view_rect.height);
|
|
g_assert_cmpint (buffer_rect.x, ==, 10);
|
|
g_assert_cmpint (buffer_rect.y, ==, 10);
|
|
|
|
test.wait_for_scanout = FALSE;
|
|
clutter_actor_queue_redraw (CLUTTER_ACTOR (stage));
|
|
g_main_loop_run (test.loop);
|
|
|
|
g_assert_cmpuint (test.scanout.fb_id, ==, 0);
|
|
|
|
g_debug ("Moving back to 0, 0");
|
|
meta_window_move_frame (window, TRUE, 0, 0);
|
|
|
|
meta_window_get_buffer_rect (window, &buffer_rect);
|
|
g_assert_cmpint (buffer_rect.width, ==, view_rect.width);
|
|
g_assert_cmpint (buffer_rect.height, ==, view_rect.height);
|
|
g_assert_cmpint (buffer_rect.x, ==, 0);
|
|
g_assert_cmpint (buffer_rect.y, ==, 0);
|
|
|
|
test.wait_for_scanout = TRUE;
|
|
clutter_actor_queue_redraw (CLUTTER_ACTOR (stage));
|
|
g_main_loop_run (test.loop);
|
|
|
|
g_assert_cmpuint (test.scanout.fb_id, >, 0);
|
|
|
|
g_signal_handler_disconnect (stage, before_update_handler_id);
|
|
g_signal_handler_disconnect (stage, before_paint_handler_id);
|
|
g_signal_handler_disconnect (stage, paint_view_handler_id);
|
|
g_signal_handler_disconnect (stage, presented_handler_id);
|
|
|
|
meta_wayland_test_driver_emit_sync_event (test_driver, 0);
|
|
meta_wayland_test_client_finish (wayland_test_client);
|
|
g_main_loop_unref (test.loop);
|
|
}
|
|
|
|
static void
|
|
init_tests (void)
|
|
{
|
|
g_test_add_func ("/backends/native/kms/render/basic",
|
|
meta_test_kms_render_basic);
|
|
g_test_add_func ("/backends/native/kms/render/client-scanout",
|
|
meta_test_kms_render_client_scanout);
|
|
}
|
|
|
|
int
|
|
main (int argc,
|
|
char **argv)
|
|
{
|
|
g_autoptr (MetaContext) context = NULL;
|
|
g_autoptr (GError) error = NULL;
|
|
|
|
context = meta_create_test_context (META_CONTEXT_TEST_TYPE_VKMS,
|
|
META_CONTEXT_TEST_FLAG_NO_X11);
|
|
g_assert (meta_context_configure (context, &argc, &argv, NULL));
|
|
|
|
test_context = context;
|
|
|
|
init_tests ();
|
|
|
|
return meta_context_test_run_tests (META_CONTEXT_TEST (context),
|
|
META_TEST_RUN_FLAG_CAN_SKIP);
|
|
}
|