Go to file
Jonas Dreßler c64803770e clutter: Bail out and warn on reentry into mapping/unmapping cycle
There's a bunch of crashes right now where the assertions in
clutter_actor_set_mapped() after calling the map/unmap() vfuncs are
failing. The only way this can happen is by re-entering
clutter_actor_set_mapped() during the map/unmap recursion.

The reason for those crashes is that the shell hides/shows some actors
in response to crossing events and key-focus changes. These in turn get
triggered by the newly introduced ungrabbing of ClutterGrabs when an
actor gets unmapped, which triggers GRAB_NOTIFY crossing events and
key-focus changes.

Since these situations are hardly avoidable (it's a valid use-case to
hide/show something in response to a crossing/key-focus event), catch
the set_mapped() call early while we reenter the mapping machinery and
log a warning instead of crashing.

Fixes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3165
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2299>
2022-04-21 10:09:59 +00:00
.gitlab/issue_templates
.gitlab-ci ci: Make run-tests.sh usable for the dist job too 2022-01-04 12:07:06 +01:00
clutter clutter: Bail out and warn on reentry into mapping/unmapping cycle 2022-04-21 10:09:59 +00:00
cogl cogl/context: Add transfer full annotation to destroy timestamp query 2022-04-05 12:40:56 +02:00
data backend/native: Only disable dmabuf screen cast when not hw accelerated 2022-02-07 19:16:45 +00:00
doc doc: Add monitor configuration documentation 2022-01-25 16:25:48 +00:00
meson build: Check NEWS for version 2021-09-05 00:15:56 +02:00
po Update Vietnamese translation 2022-04-16 07:08:54 +00:00
src core: Account ClutterStage grabs on Wayland key focus synchronization 2022-04-20 14:38:23 +00:00
subprojects
tools tools/uncrustify: Remove space between i18n function shortcuts and ( 2021-12-09 20:59:49 +01:00
.gitignore
.gitlab-ci.yml ci: Run KVM tests 2022-03-28 16:17:21 +00:00
check-style.py ci: Avoid deadlock while reading uncrustify output 2021-08-23 17:40:43 +02:00
config.h.meson meson: Allow to build without gnome-desktop 2022-03-03 15:07:38 +00:00
COPYING
HACKING.md docs: Update coding style link 2021-11-09 19:52:14 +01:00
meson_options.txt meson: Allow to build without gnome-desktop 2022-03-03 15:07:38 +00:00
meson.build build: Include KVM test enablement in summary 2022-03-28 16:17:21 +00:00
mutter.doap
NEWS Bump version to 42.0 2022-03-12 16:57:23 +01:00
README.md docs: Add README section for default branch 2021-07-18 23:14:16 +02:00

Mutter

Mutter is a Wayland display server and X11 window manager and compositor library.

When used as a Wayland display server, it runs on top of KMS and libinput. It implements the compositor side of the Wayland core protocol as well as various protocol extensions. It also has functionality related to running X11 applications using Xwayland.

When used on top of Xorg it acts as a X11 window manager and compositing manager.

It contains functionality related to, among other things, window management, window compositing, focus tracking, workspace management, keybindings and monitor configuration.

Internally it uses a fork of Cogl, a hardware acceleration abstraction library used to simplify usage of OpenGL pipelines, as well as a fork af Clutter, a scene graph and user interface toolkit.

Mutter is used by, for example, GNOME Shell, the GNOME core user interface, and by Gala, elementary OS's window manager. It can also be run standalone, using the command "mutter", but just running plain mutter is only intended for debugging purposes.

Contributing

To contribute, open merge requests at https://gitlab.gnome.org/GNOME/mutter.

It can be useful to look at the documentation available at the Wiki.

Coding style and conventions

See HACKING.md.

Git messages

Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit. Try to always prefix commit subjects with a relevant topic, such as compositor: or clutter/actor:, and it's always better to write too much in the commit message body than too little.

Default branch

The default development branch is main. If you still have a local checkout under the old name, use:

git checkout master
git branch -m master main
git fetch
git branch --unset-upstream
git branch -u origin/main
git symbolic-ref refs/remotes/origin/HEAD refs/remotes/origin/main

License

Mutter is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for detalis.