56580ea7c9
The previous logic didn't work correctly at least when priority-based preeption wasn't supported by the DRM driver, such as in the case of amdgpu. The call to glGetQueryObjecti64v would block on client work which is already in progress (most likely for the next frame) and delay notifying the ClutterFrameClock about presentation. Conveniently, the Wayland transactions mechanism guarantees that all fences of a dma-buf buffer are signalled before the buffer is included in a frame, which means that dma-buf buffers are ready for presentation when being directly scanned-out. Direct scanout is only supported for dma-buf buffers too, which means that all buffers going through direct scanout are effectively ready and require no GPU rendering before presentation. Assuming zero rendering time for dma-buf buffers going through direct scanout simplifies the code and removes the need for glGetQueryObjecti64v, thus avoiding the aforementioned issue where it could block for longer than expected. Closes: https://gitlab.gnome.org/GNOME/mutter/-/issues/2766 Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3080>
66 lines
2.1 KiB
C
66 lines
2.1 KiB
C
/*
|
|
* Copyright (C) 2018 Canonical Ltd.
|
|
* Copyright (C) 2019-2020 Red Hat Inc.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation; either version 2 of the
|
|
* License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
|
|
* 02111-1307, USA.
|
|
*/
|
|
|
|
#ifndef META_DRM_BUFFER_PRIVATE_H
|
|
#define META_DRM_BUFFER_PRIVATE_H
|
|
|
|
#include "backends/native/meta-backend-native-types.h"
|
|
#include "backends/native/meta-drm-buffer.h"
|
|
|
|
typedef struct _MetaDrmFbArgs
|
|
{
|
|
uint32_t width;
|
|
uint32_t height;
|
|
uint32_t format;
|
|
uint32_t handles[4];
|
|
uint32_t offsets[4];
|
|
uint32_t strides[4];
|
|
uint64_t modifiers[4];
|
|
uint32_t handle;
|
|
} MetaDrmFbArgs;
|
|
|
|
struct _MetaDrmBufferClass
|
|
{
|
|
GObjectClass parent_class;
|
|
|
|
int (* export_fd) (MetaDrmBuffer *buffer,
|
|
GError **error);
|
|
|
|
gboolean (* ensure_fb_id) (MetaDrmBuffer *buffer,
|
|
GError **error);
|
|
|
|
int (* get_width) (MetaDrmBuffer *buffer);
|
|
int (* get_height) (MetaDrmBuffer *buffer);
|
|
int (* get_stride) (MetaDrmBuffer *buffer);
|
|
int (* get_bpp) (MetaDrmBuffer *buffer);
|
|
uint32_t (* get_format) (MetaDrmBuffer *buffer);
|
|
int (* get_offset) (MetaDrmBuffer *buffer,
|
|
int plane);
|
|
uint64_t (* get_modifier) (MetaDrmBuffer *buffer);
|
|
};
|
|
|
|
MetaDeviceFile * meta_drm_buffer_get_device_file (MetaDrmBuffer *buffer);
|
|
|
|
gboolean meta_drm_buffer_do_ensure_fb_id (MetaDrmBuffer *buffer,
|
|
const MetaDrmFbArgs *fb_args,
|
|
GError **error);
|
|
|
|
#endif /* META_DRM_BUFFER_PRIVATE_H */
|