![Pekka Paalanen](/assets/img/avatar_default.png)
This bit of code was more or less duplicated in meta-renderer-native-gles3.c and meta-wayland-dma-buf.c. Start consolidating the two implementations by moving the *-gles3.c function into meta-egl.c and generalizing it so it could also accommodate the meta-wayland-dma-buf.c usage. The workaround in the *-gles3.c implementation is moved to the caller. It is the caller's responsibility to check for the existence of the appropriate EGL extensions. Commit 6f59e4858e24c828e3ab0e611d36dfaaded1b272 worked around the lack of EGL_EXT_image_dma_buf_import_modifiers with the assumption that if the modifier is linear, there is no need to pass it into EGL. The problem is that not passing a modifier explicitly to EGL invokes implementation-defined behaviour, so we should not have that workaround in meta-egl.c. This patch intends to be pure refactoring, no behavioral changes. The one change is the addition of g_assert to catch overwriting arbitrary memory. https://gitlab.gnome.org/GNOME/mutter/merge_requests/615
Mutter
Mutter is a Wayland display server and X11 window manager and compositor library.
When used as a Wayland display server, it runs on top of KMS and libinput. It implements the compositor side of the Wayland core protocol as well as various protocol extensions. It also has functionality related to running X11 applications using Xwayland.
When used on top of Xorg it acts as a X11 window manager and compositing manager.
It contains functionality related to, among other things, window management, window compositing, focus tracking, workspace management, keybindings and monitor configuration.
Internally it uses a fork of Cogl, a hardware acceleration abstraction library used to simplify usage of OpenGL pipelines, as well as a fork af Clutter, a scene graph and user interface toolkit.
Mutter is used by, for example, GNOME Shell, the GNOME core user interface, and by Gala, elementary OS's window manager. It can also be run standalone, using the command "mutter", but just running plain mutter is only intended for debugging purposes.
Contributing
To contribute, open merge requests at https://gitlab.gnome.org/GNOME/mutter.
The coding style used is primarily the GNU flavor of the GNOME coding
style
with some minor additions such as preferring stdint.h
types over GLib
fundamental types, and a soft 80 character line limit. However, in general,
look at the file you're editing for inspiration.
Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit.
License
Mutter is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for detalis.