Go to file
Daniel van Vugt 8655bc5d8d clutter: Fix offscreen-effect painting of clones
`ClutterOffscreenEffect` had been getting the wrong bounding box in the
case of clones and descendents of clones, causing visibly incorrect
clipping. This was due to `clutter_actor_get_paint_box` only ever being
given the source actor during a paint (which is correct) and not the clone.
Even if we weren't painting a clone but an offscreened descendent of a
clone (like in gnome-shell's desktop zoom), we would get the wrong result.

Fortunately we don't need to know the actual clone/actor being painted so
don't need to call the problematic `clutter_actor_get_paint_box` at all.
The solution is to only keep untransformed rendering in the FBO and leave
the correct transformation for later. The correct clone/actor's
transformation is already set for us as the current cogl modelview matrix
by `clutter_actor_paint`.

Bonus optimization: This all means we don't need to keep `last_matrix_drawn`
or force a full repaint every time some part of the transformation changes.
Because the FBO contents are no longer affected by transformations. As it
should be. In other words, offscreen-effected actors can now move around
on screen without themselves being repainted.

Special thanks to Mai Lavelle for identifying the cause of the problem.

Fixes:
https://bugzilla.gnome.org/show_bug.cgi?id=789050,
https://bugzilla.gnome.org/show_bug.cgi?id=659523#c9,
https://gitlab.gnome.org/GNOME/mutter/issues/196,
https://gitlab.gnome.org/GNOME/mutter/issues/282,
https://gitlab.gnome.org/GNOME/gnome-shell/issues/387,
https://launchpad.net/bugs/1767648,
https://launchpad.net/bugs/1779615
2019-01-24 17:00:25 +00:00
.gitlab-ci cogl/path: Don't depend on GL/glu.h 2019-01-22 19:06:14 +01:00
clutter clutter: Fix offscreen-effect painting of clones 2019-01-24 17:00:25 +00:00
cogl meson: Don't list libraries private dependencies in pc files 2019-01-23 13:03:40 +00:00
data Drop Autotools 2019-01-10 11:50:54 -02:00
doc Remove obsolete .cvsignore files 2019-01-10 11:50:54 -02:00
po Remove po/ChangeLog 2019-01-12 14:53:13 +01:00
src meta, startup-notification: Make type declarations public 2019-01-24 16:38:09 +00:00
tools tools: Remove obsolete ppa-magic.py 2018-11-30 11:12:12 +08:00
.gitignore project: Update gitignore 2019-01-10 11:50:54 -02:00
.gitlab-ci.yml gitlab-ci.yml: Change build step build type to debugoptimized 2019-01-23 21:05:51 +00:00
config.h.meson build: Make libcanberra no longer optional 2019-01-08 15:58:11 +01:00
COPYING Updated obsolete FSF postal address in COPYING 2014-01-12 08:44:30 +07:00
meson_options.txt build: Make libcanberra no longer optional 2019-01-08 15:58:11 +01:00
meson.build meson: Hide symbols by default in clutter 2019-01-23 13:03:40 +00:00
mutter.doap Replace Bugzilla by Gitlab URL in DOAP file 2018-12-15 23:50:01 +01:00
NEWS Bump version to 3.31.4 2019-01-10 20:07:55 +01:00
README.md README: Mention usage by Gala 2018-11-08 17:11:27 +01:00

Mutter

Mutter is a Wayland display server and X11 window manager and compositor library.

When used as a Wayland display server, it runs on top of KMS and libinput. It implements the compositor side of the Wayland core protocol as well as various protocol extensions. It also has functionality related to running X11 applications using Xwayland.

When used on top of Xorg it acts as a X11 window manager and compositing manager.

It contains functionality related to, among other things, window management, window compositing, focus tracking, workspace management, keybindings and monitor configuration.

Internally it uses a fork of Cogl, a hardware acceleration abstraction library used to simplify usage of OpenGL pipelines, as well as a fork af Clutter, a scene graph and user interface toolkit.

Mutter is used by, for example, GNOME Shell, the GNOME core user interface, and by Gala, elementary OS's window manager. It can also be run standalone, using the command "mutter", but just running plain mutter is only intended for debugging purposes.

License

Mutter is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for detalis.