4ff54997b6
Realizing a cursor will assume view related state objects are valid so they can mark them as dirty. This assumption broke when there were a scale changed that happened with multiple CRTCs, as we'd create view object by view object as we realized the texture. Realizing the texture would trigger a signal that had the handler assuming the validity of all view objects, but if we only had gotten to the first, the second view would not be there yet, thus we'd be doing a NULL pointer dereference. Creating the view objects first, then handling the updating avoids this problem by making the already done assumption valid on hotplugs. The test case added tests exactly this series of events, and uses a virtual monitor as a cheap trick to make the KMS CRTC based view the first one, and an arbitrary view the second that previously had its view object initialized too late. Closes: https://gitlab.gnome.org/GNOME/mutter/-/issues/3012 Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3262>
30 lines
1.1 KiB
C
30 lines
1.1 KiB
C
/*
|
|
* Copyright (C) 2021 Red Hat
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation; either version 2 of the
|
|
* License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "backends/native/meta-crtc-native.h"
|
|
|
|
#define META_TYPE_CRTC_VIRTUAL (meta_crtc_virtual_get_type ())
|
|
META_EXPORT_TEST
|
|
G_DECLARE_FINAL_TYPE (MetaCrtcVirtual, meta_crtc_virtual,
|
|
META, CRTC_VIRTUAL,
|
|
MetaCrtcNative)
|
|
|
|
MetaCrtcVirtual * meta_crtc_virtual_new (MetaBackend *backend,
|
|
uint64_t id);
|