In a similar vein to commit 8fd55fef853. This notably failed when setting the focus on the stage (eg. to redirect key events to Clutter actors). Deeper in MetaDisplay focus updating machinery, it would check meta_stage_is_focused() which would still return FALSE at the time it's called. This would not typically have side effects, but our "App does not respond" dialogs see the focus change under their feet, so they try to bring themselves to focus again. This results in a feedback loop. Changing the order results in later checks on the X11 POV of the focus being correct, so focus is not mistakenly stolen from the close dialog, and it actually succeeds in keeping the key focus. Fixes: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1607 https://gitlab.gnome.org/GNOME/mutter/merge_requests/876
Mutter
Mutter is a Wayland display server and X11 window manager and compositor library.
When used as a Wayland display server, it runs on top of KMS and libinput. It implements the compositor side of the Wayland core protocol as well as various protocol extensions. It also has functionality related to running X11 applications using Xwayland.
When used on top of Xorg it acts as a X11 window manager and compositing manager.
It contains functionality related to, among other things, window management, window compositing, focus tracking, workspace management, keybindings and monitor configuration.
Internally it uses a fork of Cogl, a hardware acceleration abstraction library used to simplify usage of OpenGL pipelines, as well as a fork af Clutter, a scene graph and user interface toolkit.
Mutter is used by, for example, GNOME Shell, the GNOME core user interface, and by Gala, elementary OS's window manager. It can also be run standalone, using the command "mutter", but just running plain mutter is only intended for debugging purposes.
Contributing
To contribute, open merge requests at https://gitlab.gnome.org/GNOME/mutter.
The coding style used is primarily the GNU flavor of the GNOME coding
style
with some minor additions such as preferring stdint.h
types over GLib
fundamental types, and a soft 80 character line limit. However, in general,
look at the file you're editing for inspiration.
Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit.
License
Mutter is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for detalis.