6e0cfd3e55
When testing a laptop with intel and DisplayLink devices, attempting to set the DL output as the only active output resulted in GNOME/Wayland freezing. The main event loop was running fine, but nothing on screen would get updated once the DL output become the only one. This patch fixes that issue. DisplayLink USB 3 devices use an out-of-tree kernel DRM driver called EVDI. EVDI can sometimes fail drmModePageFlip(). For me, the flip fails reliably when hotplugging the DL dock and when changing display configuration to DL only. Mutter has a workaround for failing flips, it just calls drmModeSetCrtc() and that succeeds. What does not work reliably in the fallback path is Mutter keeping track of the pageflip. Since drmModePageFlip() failed, there will not be a pageflip event coming and instead Mutter queues a callback in its stead. When you have more than one output, some other output repainting will attempt to swap buffers and calls wait_for_pending_flips() which has the side-effect of dispatching any queued flip callbacks. With multiple outputs, you don't get stuck (unless they all fail the exact same way at the same time?). When you have only one output, it cannot proceed to repaint and buffer swap because the pageflip is not marked complete yet. Nothing dispatches the flip callback, leading to the freeze. The flip callback is intended to be an idle callback, implemented with a GSource. It is supposed to be called as soon as execution returns to the main event loop. The setup of the GSource is incomplete, so it will never dispatch. Fix the GSource setup by setting its ready-time to be always in the past. That gets it dispatched on the next cycle of the main event loop. This is now the default behavior for all sources created by meta_kms_add_source_in_impl(). Sources that need a delay continue to do that by overriding the ready-time explicitly. An alternative solution could have been to implement GSource prepare and check callbacks returning TRUE. However, since meta_kms_add_source_in_impl() is used by flip retry code as well, and that code needs a delay through the ready-time, I was afraid I might break the flip retry code. Hence I decided to use ready-time instead. https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1209 |
||
|---|---|---|
| .gitlab/issue_templates | ||
| .gitlab-ci | ||
| clutter | ||
| cogl | ||
| data | ||
| doc | ||
| meson | ||
| po | ||
| src | ||
| tools | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| config.h.meson | ||
| COPYING | ||
| meson_options.txt | ||
| meson.build | ||
| mutter.doap | ||
| NEWS | ||
| README.md | ||
Mutter
Mutter is a Wayland display server and X11 window manager and compositor library.
When used as a Wayland display server, it runs on top of KMS and libinput. It implements the compositor side of the Wayland core protocol as well as various protocol extensions. It also has functionality related to running X11 applications using Xwayland.
When used on top of Xorg it acts as a X11 window manager and compositing manager.
It contains functionality related to, among other things, window management, window compositing, focus tracking, workspace management, keybindings and monitor configuration.
Internally it uses a fork of Cogl, a hardware acceleration abstraction library used to simplify usage of OpenGL pipelines, as well as a fork af Clutter, a scene graph and user interface toolkit.
Mutter is used by, for example, GNOME Shell, the GNOME core user interface, and by Gala, elementary OS's window manager. It can also be run standalone, using the command "mutter", but just running plain mutter is only intended for debugging purposes.
Contributing
To contribute, open merge requests at https://gitlab.gnome.org/GNOME/mutter.
The coding style used is primarily the GNU flavor of the GNOME coding
style
with some minor additions such as preferring stdint.h types over GLib
fundamental types, and a soft 80 character line limit. However, in general,
look at the file you're editing for inspiration.
Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit.
License
Mutter is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for detalis.