05efcb4b21
Move the use count from a separate MetaWaylandBufferRef struct to the MetaWaylandBuffer class, and remove the former. The buffer use count is now incremented already in meta_wayland_surface_commit, since the Wayland protocol defines the buffer to be in use by the compositor at that point. If the buffer attachment ends up being dropped again before it is applied to the surface state (e.g. because another buffer is committed to a synchronized sub-surface before the parent surface is committed), the use count is now decremented, and a buffer release event is sent if the use count drops to 0. Buffer release events were previously incorrectly not sent under these circumstances. Test case: Run the weston-subsurfaces demo with the -r1 and/or -t1 command line parameter. Resize the window. Before this change, weston-subsurfaces would freeze or abort after a few resize operations, because mutter failed to send release events and the client ran out of usable buffers. v2: * Handle NULL priv->buffer_ref in meta_wayland_cursor_surface_apply_state. v3: * Remove MetaWaylandBufferRef altogether, move the use count tracking to MetaWaylandBuffer itself. Much simpler, and doesn't run into lifetime issues when mutter shuts down. v4: * Warn if use count isn't 0 in meta_wayland_buffer_finalize. * Keep pending_buffer_resource_destroyed for attached but not yet committed buffers. If the client attaches a buffer and then destroys it before commit, we ignore the buffer attachement, same as before this MR. v5: * Rebase on top of new commit which splits up surface->texture. * MetaWaylandSurfaceState::buffer can only be non-NULL if ::newly_attached is TRUE, simplify accordingly. Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1880>
110 lines
4.0 KiB
C
110 lines
4.0 KiB
C
/* -*- mode: C; c-file-style: "gnu"; indent-tabs-mode: nil; -*- */
|
|
|
|
/*
|
|
* Copyright (C) 2014 Endless Mobile
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation; either version 2 of the
|
|
* License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
|
|
* 02111-1307, USA.
|
|
*
|
|
* Written by:
|
|
* Jasper St. Pierre <jstpierre@mecheye.net>
|
|
*/
|
|
|
|
#ifndef META_WAYLAND_BUFFER_H
|
|
#define META_WAYLAND_BUFFER_H
|
|
|
|
#include <cairo.h>
|
|
#include <wayland-server.h>
|
|
|
|
#include "cogl/cogl.h"
|
|
#include "wayland/meta-wayland-types.h"
|
|
#include "wayland/meta-wayland-egl-stream.h"
|
|
#include "wayland/meta-wayland-dma-buf.h"
|
|
#include "wayland/meta-wayland-single-pixel-buffer.h"
|
|
|
|
typedef enum _MetaWaylandBufferType
|
|
{
|
|
META_WAYLAND_BUFFER_TYPE_UNKNOWN,
|
|
META_WAYLAND_BUFFER_TYPE_SHM,
|
|
META_WAYLAND_BUFFER_TYPE_EGL_IMAGE,
|
|
#ifdef HAVE_WAYLAND_EGLSTREAM
|
|
META_WAYLAND_BUFFER_TYPE_EGL_STREAM,
|
|
#endif
|
|
META_WAYLAND_BUFFER_TYPE_DMA_BUF,
|
|
META_WAYLAND_BUFFER_TYPE_SINGLE_PIXEL,
|
|
} MetaWaylandBufferType;
|
|
|
|
struct _MetaWaylandBuffer
|
|
{
|
|
GObject parent;
|
|
|
|
MetaWaylandCompositor *compositor;
|
|
struct wl_resource *resource;
|
|
struct wl_listener destroy_listener;
|
|
|
|
unsigned int use_count;
|
|
|
|
gboolean is_y_inverted;
|
|
|
|
MetaWaylandBufferType type;
|
|
|
|
struct {
|
|
CoglTexture *texture;
|
|
} egl_image;
|
|
|
|
#ifdef HAVE_WAYLAND_EGLSTREAM
|
|
struct {
|
|
MetaWaylandEglStream *stream;
|
|
CoglTexture *texture;
|
|
} egl_stream;
|
|
#endif
|
|
|
|
struct {
|
|
MetaWaylandDmaBufBuffer *dma_buf;
|
|
CoglTexture *texture;
|
|
} dma_buf;
|
|
|
|
struct {
|
|
MetaWaylandSinglePixelBuffer *single_pixel_buffer;
|
|
CoglTexture *texture;
|
|
} single_pixel;
|
|
};
|
|
|
|
#define META_TYPE_WAYLAND_BUFFER (meta_wayland_buffer_get_type ())
|
|
G_DECLARE_FINAL_TYPE (MetaWaylandBuffer, meta_wayland_buffer,
|
|
META, WAYLAND_BUFFER, GObject);
|
|
|
|
MetaWaylandBuffer * meta_wayland_buffer_from_resource (MetaWaylandCompositor *compositor,
|
|
struct wl_resource *resource);
|
|
struct wl_resource * meta_wayland_buffer_get_resource (MetaWaylandBuffer *buffer);
|
|
gboolean meta_wayland_buffer_is_realized (MetaWaylandBuffer *buffer);
|
|
gboolean meta_wayland_buffer_realize (MetaWaylandBuffer *buffer);
|
|
gboolean meta_wayland_buffer_attach (MetaWaylandBuffer *buffer,
|
|
CoglTexture **texture,
|
|
GError **error);
|
|
CoglSnippet * meta_wayland_buffer_create_snippet (MetaWaylandBuffer *buffer);
|
|
void meta_wayland_buffer_inc_use_count (MetaWaylandBuffer *buffer);
|
|
void meta_wayland_buffer_dec_use_count (MetaWaylandBuffer *buffer);
|
|
gboolean meta_wayland_buffer_is_y_inverted (MetaWaylandBuffer *buffer);
|
|
void meta_wayland_buffer_process_damage (MetaWaylandBuffer *buffer,
|
|
CoglTexture *texture,
|
|
cairo_region_t *region);
|
|
CoglScanout * meta_wayland_buffer_try_acquire_scanout (MetaWaylandBuffer *buffer,
|
|
CoglOnscreen *onscreen);
|
|
|
|
void meta_wayland_init_shm (MetaWaylandCompositor *compositor);
|
|
|
|
#endif /* META_WAYLAND_BUFFER_H */
|