1d7920872d
When drmModePageFlip() or drmModeAtomicCommit() unexpectedly failed (e.g. ENOSPC, which has been seen in the wild), this failure was not handled very gracefully. The page flip listener for the scanout was left in the MetaKmsUpdate, meaning when the primary plane composition was later page flipped, two page flip listeners were added, one for the primary plane, and one for the scanout. This caused the 'page-flipped' event to be handled twice, the second time being fatal. Handle this by making 'no-discard' listener flag be somewhat reversed, and say 'drop-on-error', and then drop all 'drop-on-error' listeners when a MetaKmsUpdate failed to be processed. Also for a "preserve" flagged update, don't ever trigger "discard" callbacks just yet, as preserved updates are used again for the primary plane composition, in order to not miss e.g. CRTC gamma updates, or cursor plane updates, which were added separately. Closes: https://gitlab.gnome.org/GNOME/mutter/-/issues/1809 Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1910>
51 lines
1.9 KiB
C
51 lines
1.9 KiB
C
/*
|
|
* Copyright (C) 2018 Red Hat
|
|
* Copyright (C) 2019 DisplayLink (UK) Ltd.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation; either version 2 of the
|
|
* License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
|
|
* 02111-1307, USA.
|
|
*/
|
|
|
|
#ifndef META_KMS_IMPL_H
|
|
#define META_KMS_IMPL_H
|
|
|
|
#include "backends/native/meta-kms-impl-device.h"
|
|
#include "backends/native/meta-kms-page-flip-private.h"
|
|
#include "backends/native/meta-kms.h"
|
|
|
|
#define META_TYPE_KMS_IMPL (meta_kms_impl_get_type ())
|
|
G_DECLARE_FINAL_TYPE (MetaKmsImpl, meta_kms_impl,
|
|
META, KMS_IMPL, GObject)
|
|
|
|
MetaKms * meta_kms_impl_get_kms (MetaKmsImpl *impl);
|
|
|
|
MetaKmsFeedback * meta_kms_impl_process_update (MetaKmsImpl *impl,
|
|
MetaKmsUpdate *update,
|
|
MetaKmsUpdateFlag flags);
|
|
|
|
void meta_kms_impl_add_impl_device (MetaKmsImpl *impl,
|
|
MetaKmsImplDevice *impl_device);
|
|
|
|
void meta_kms_impl_remove_impl_device (MetaKmsImpl *impl,
|
|
MetaKmsImplDevice *impl_device);
|
|
|
|
void meta_kms_impl_discard_pending_page_flips (MetaKmsImpl *impl);
|
|
|
|
void meta_kms_impl_prepare_shutdown (MetaKmsImpl *impl);
|
|
|
|
MetaKmsImpl * meta_kms_impl_new (MetaKms *kms);
|
|
|
|
#endif /* META_KMS_IMPL_H */
|