brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Read-only mirror of https://gitlab.gnome.org/GNOME/mutter
24,699 Commits 187 Branches 380 Tags 94 MiB
C 98.9%
Meson 0.7%
Python 0.3%
2f27b8d5fa
Go to file
Jonas Ådahl 2f27b8d5fa window-actor: Handle changing surface actor on window reparenting 
The commit f2f4af0d50 missed one situation
where mutter does things differently, i.e. changes what surface actor is
associated with a given window actor: reparenting a Xwayland window when
changing whether it is decorated.

To summarize, there are three types of window actors:

X11 window actors - directly tied to the backing X11 window. The
corresponding surface actor is directly owned by the window actor and
will never change.

Wayland window actors - gets its surface actor from MetaWaylandSurface
at construction. A single MetaWaylandSurface may create and destroy
multiple window actors over time, but a single window actor will never
change surface actor.

Xwayland window actors - a mix between the above two types; the window
corresponds to the X11 window, and so does the window actor, but the
surface itself comes from the MetaWaylandSurface.

Normally when a X11 window is unmapped, the corresponding MetaWindow is
unmanaged. With Xwayland, this happens indirectly via the destruction of
the wl_surface. The exception to this is windows that are reparented
during changing their decoration state - in this case on plain X11, the
MetaWindow stays alive. With Xwayland however, there is a race
condition; since the MetaWindow is tied to the wl_surface, if we receive
the new surface ID atom before the destruction of the old wl_surface,
we'll try to associate the existing MetaWindow and MetaWindowActor with
the new wl_surface, hitting the assert. If the surface destruction
arrives first, the MetaWindow and MetaWindowActor will be disposed, and
the we wouldn't hit the assert.

To handle this race gracefully, reinstate handling of replacing the
surface actor of an existing window actor, to handle this race, as it
was handled before.

Eventually, it should be reconsidered whether the MetaWindow lifetime is
tied to the wl_surface or if it should be changed to be consistent with
plain X11, as this re-exposes another bug where the X11 client and
mutter will enter a feedback loop where the window is repeatedly
remapped. See https://gitlab.freedesktop.org/xorg/xserver/issues/740.

Fixes: https://gitlab.gnome.org/GNOME/mutter/issues/709

https://gitlab.gnome.org/GNOME/mutter/merge_requests/773
2019-09-05 07:43:40 +00:00
.gitlab-ci ci: Add gnome-autoar to Dockerfile 2019-08-21 15:10:44 +00:00
clutter clutter/input-pointer-a11y: Restore pointer a11y on resume 2019-09-02 17:27:17 +00:00
cogl cogl: Remove GLX "threaded swap wait" used on Nvidia 2019-09-02 18:12:10 +08:00
data wayland: Add setting/api to check the policy to set up the X11 display 2019-08-06 00:41:36 +00:00
doc Remove obsolete .cvsignore files 2019-01-10 11:50:54 -02:00
meson build: Add postinstall script 2019-08-27 09:57:54 +00:00
po Update Korean translation 2019-09-05 06:35:18 +00:00
src window-actor: Handle changing surface actor on window reparenting 2019-09-05 07:43:40 +00:00
tools tools: Remove obsolete ppa-magic.py 2018-11-30 11:12:12 +08:00
.gitignore project: Update gitignore 2019-01-10 11:50:54 -02:00
.gitlab-ci.yml ci: Don't build gnome-shell's man pages 2019-08-21 22:46:41 +02:00
config.h.meson xwayland: Fix build without <sys/random.h> 2019-06-20 12:37:18 +02:00
COPYING Updated obsolete FSF postal address in COPYING 2014-01-12 08:44:30 +07:00
meson_options.txt cogl: Add libsysprof capture based tracing 2019-05-31 11:55:56 -03:00
meson.build Bump version to 3.33.92 2019-09-04 20:49:07 +02:00
mutter.doap Replace Bugzilla by Gitlab URL in DOAP file 2018-12-15 23:50:01 +01:00
NEWS Bump version to 3.33.92 2019-09-04 20:49:07 +02:00
README.md README: Add contribution section 2019-02-14 15:38:46 +01:00

README.md

Mutter

Mutter is a Wayland display server and X11 window manager and compositor library.

When used as a Wayland display server, it runs on top of KMS and libinput. It implements the compositor side of the Wayland core protocol as well as various protocol extensions. It also has functionality related to running X11 applications using Xwayland.

When used on top of Xorg it acts as a X11 window manager and compositing manager.

It contains functionality related to, among other things, window management, window compositing, focus tracking, workspace management, keybindings and monitor configuration.

Internally it uses a fork of Cogl, a hardware acceleration abstraction library used to simplify usage of OpenGL pipelines, as well as a fork af Clutter, a scene graph and user interface toolkit.

Mutter is used by, for example, GNOME Shell, the GNOME core user interface, and by Gala, elementary OS's window manager. It can also be run standalone, using the command "mutter", but just running plain mutter is only intended for debugging purposes.

Contributing

To contribute, open merge requests at https://gitlab.gnome.org/GNOME/mutter.

The coding style used is primarily the GNU flavor of the GNOME coding style with some minor additions such as preferring stdint.h types over GLib fundamental types, and a soft 80 character line limit. However, in general, look at the file you're editing for inspiration.

Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit.

License

Mutter is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for detalis.