brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

wayland/surface: Disable WL_SURFACE_ERROR_INVALID_SIZE check again

Browse Source 
The check was introduces in ab17c98c94
but turned out to trigger client crashes in common cases.
Turn it into a warning for now until clients are fixed.

Closes https://gitlab.gnome.org/GNOME/mutter/-/issues/2083
Closes https://gitlab.gnome.org/GNOME/mutter/-/issues/2163

Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2335>
This commit is contained in:
Robert Mader 2022-03-10 00:19:21 +01:00 committed by Marge Bot
parent 0280b0aaa5
commit f9857cb8bd
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/wayland/meta-wayland-surface.c
View File

@ -791,12 +791,16 @@ meta_wayland_surface_apply_state (MetaWaylandSurface *surface,
if ((get_buffer_width (surface) % surface->scale != 0) ||
(get_buffer_height (surface) % surface->scale != 0))
{
wl_resource_post_error (surface->resource, WL_SURFACE_ERROR_INVALID_SIZE,
"Buffer size (%dx%d) must be an integer multiple "
"of the buffer_scale (%d)",
get_buffer_width (surface),
get_buffer_height (surface), surface->scale);
goto cleanup;
struct wl_resource *resource = surface->resource;
pid_t pid;
wl_client_get_credentials (wl_resource_get_client (resource), &pid, NULL,
NULL);
g_warning ("Bug in client with pid %ld: Buffer size (%dx%d) is not an"
"integer multiple of the buffer_scale (%d).", (long) pid,
get_buffer_width (surface), get_buffer_height (surface),
surface->scale);
}
if (state->has_new_buffer_transform)