brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

compositor: Skip windows not visible to the compositor

Browse Source 
The compositor will automatically unredirect the top most window which
is fully visible on screen. When unredirecting windows, it also shapes
the compositor overlay window (COW) so that other redirected windows
still shows correctly.

The function `get_top_visible_window_actor()` however will simply walks
down the window list, so if a window is placed on a layer above and
unredirected, then iconified by the client, it will still be picked up
by `get_top_visible_window_actor()` and he compositor will reckon it's
still unredirected while not in a visible state anymore, thus leaving a
black area on screen.

Make sure we skip the windows not known to the compositor while picking
the top visible window actor to avoid this issue.

Closes: https://gitlab.gnome.org/GNOME/mutter/issues/306

(cherry picked from commit 2fb3db7659)
This commit is contained in:
Olivier Fourdan 2018-09-19 16:08:52 +02:00
parent 037d9915d5
commit f7658ac5f0
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/compositor/compositor.c
View File

@ -798,6 +798,7 @@ meta_compositor_hide_window (MetaCompositor *compositor,
{ {
MetaWindowActor *window_actor = META_WINDOW_ACTOR (meta_window_get_compositor_private (window)); MetaWindowActor *window_actor = META_WINDOW_ACTOR (meta_window_get_compositor_private (window));
meta_window_actor_hide (window_actor, effect); meta_window_actor_hide (window_actor, effect);
meta_stack_tracker_queue_sync_stack (compositor->display->screen->stack_tracker);
} }
void void
@ -944,6 +945,9 @@ get_top_visible_window_actor (MetaCompositor *compositor)
MetaWindow *window = meta_window_actor_get_meta_window (window_actor); MetaWindow *window = meta_window_actor_get_meta_window (window_actor);
MetaRectangle buffer_rect; MetaRectangle buffer_rect;
if (!window->visible_to_compositor)
continue;
meta_window_get_buffer_rect (window, &buffer_rect); meta_window_get_buffer_rect (window, &buffer_rect);
if (meta_rectangle_overlap (&compositor->display->screen->rect, if (meta_rectangle_overlap (&compositor->display->screen->rect,