brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

backends/remote-access-controller: Own and free the session managers

Browse Source 
We were leaking the session managers list, but at this point I feel it
looks cleaner to also own it fully

Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3788>
This commit is contained in:
Marco Trevisan (Treviño) 2024-05-29 20:40:55 +02:00 committed by Marge Bot
parent c33a02dd32
commit f74a46d98d
1 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/backends/meta-remote-access-controller.c
View File

@ -194,7 +194,7 @@ meta_remote_access_controller_add (MetaRemoteAccessController *controller,
MetaDbusSessionManager *session_manager) MetaDbusSessionManager *session_manager)
{ {
controller->session_managers = g_list_append (controller->session_managers, controller->session_managers = g_list_append (controller->session_managers,
session_manager); g_object_ref (session_manager));
} }
static void static void
@ -274,9 +274,23 @@ meta_remote_access_controller_init (MetaRemoteAccessController *controller)
{ {
} }
static void
meta_remote_access_handle_finalize (GObject *object)
{
MetaRemoteAccessController *controller = META_REMOTE_ACCESS_CONTROLLER (object);
g_clear_list (&controller->session_managers, g_object_unref);
G_OBJECT_CLASS (meta_remote_access_controller_parent_class)->finalize (object);
}
static void static void
meta_remote_access_controller_class_init (MetaRemoteAccessControllerClass *klass) meta_remote_access_controller_class_init (MetaRemoteAccessControllerClass *klass)
{ {
GObjectClass *object_class = G_OBJECT_CLASS (klass);
object_class->finalize = meta_remote_access_handle_finalize;
controller_signals[CONTROLLER_NEW_HANDLE] = controller_signals[CONTROLLER_NEW_HANDLE] =
g_signal_new ("new-handle", g_signal_new ("new-handle",
G_TYPE_FROM_CLASS (klass), G_TYPE_FROM_CLASS (klass),