brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

prefs: Switch meta_warning() to g_warning()

Browse Source 
This again also makes some warning log entries engulf debug log entries
since they would always warning immediately after.

Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/4005>
This commit is contained in:
Jonas Ådahl
2024-12-31 00:11:30 +01:00
committed by Marge Bot
parent 978054a0d0
commit f2ecfc9af3
1 changed files with 13 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/core/prefs.c
View File

@ -1137,7 +1137,7 @@ maybe_give_disable_workarounds_warning (void)
{ {
first_disable = FALSE; first_disable = FALSE;
meta_warning ("Workarounds for broken applications disabled. " g_warning ("Workarounds for broken applications disabled. "
"Some applications may not behave properly."); "Some applications may not behave properly.");
} }
} }
@ -1227,10 +1227,8 @@ mouse_button_mods_handler (GVariant *value,
if (!string_value || !meta_parse_modifier (string_value, &mods)) if (!string_value || !meta_parse_modifier (string_value, &mods))
{ {
meta_topic (META_DEBUG_KEYBINDINGS, g_warning ("Failed to parse new GSettings value: "
"Failed to parse new GSettings value"); "\"%s\" found in configuration database is "
meta_warning ("\"%s\" found in configuration database is "
"not a valid value for mouse button modifier", "not a valid value for mouse button modifier",
string_value); string_value);
@ -1770,9 +1768,9 @@ update_binding (MetaKeyPref *binding,
if (!meta_parse_accelerator (strokes[i], combo)) if (!meta_parse_accelerator (strokes[i], combo))
{ {
meta_topic (META_DEBUG_KEYBINDINGS, g_warning ("Failed to parse new GSettings value: "
"Failed to parse new GSettings value"); "\"%s\" found in configuration database is not a valid "
meta_warning ("\"%s\" found in configuration database is not a valid value for keybinding \"%s\"", "value for keybinding \"%s\"",
strokes[i], binding->name); strokes[i], binding->name);
g_free (combo); g_free (combo);
@ -1940,7 +1938,7 @@ meta_prefs_add_keybinding (const char *name,
if (g_hash_table_lookup (key_bindings, name)) if (g_hash_table_lookup (key_bindings, name))
{ {
meta_warning ("Trying to re-add keybinding \"%s\".", name); g_warning ("Trying to re-add keybinding \"%s\".", name);
return FALSE; return FALSE;
} }
@ -1990,13 +1988,13 @@ meta_prefs_remove_keybinding (const char *name)
pref = g_hash_table_lookup (key_bindings, name); pref = g_hash_table_lookup (key_bindings, name);
if (!pref) if (!pref)
{ {
meta_warning ("Trying to remove non-existent keybinding \"%s\".", name); g_warning ("Trying to remove non-existent keybinding \"%s\".", name);
return FALSE; return FALSE;
} }
if (pref->builtin) if (pref->builtin)
{ {
meta_warning ("Trying to remove builtin keybinding \"%s\".", name); g_warning ("Trying to remove builtin keybinding \"%s\".", name);
return FALSE; return FALSE;
} }