brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

kms/impl-device/atomic: Fix stack overflow

Browse Source 
Intel has started to advertise big gamma LUT sizes on some hardware
because the hardware supports segmented LUTs. This means they have a lot
more precision at certain segments then others. The uAPI can't expose
this functionality meaningfully so they chose to expose a huge number of
TAPs to sample from to their segmented LUT.

This increase in uAPI LUT size resulted in stack overflows because we
allocated the LUT on the stack. This commit moves it to the heap
instead.

Closes: https://gitlab.gnome.org/GNOME/mutter/-/issues/3064
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3322>
This commit is contained in:
Sebastian Wick 2023-10-10 16:05:14 +02:00 committed by Marge Bot
parent 9b663f44e6
commit ed06820035
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/backends/native/meta-kms-impl-device-atomic.c
View File

@ -675,10 +675,12 @@ process_crtc_color_updates (MetaKmsImplDevice *impl_device,
if (color_update->gamma.has_update) if (color_update->gamma.has_update)
{ {
MetaGammaLut *gamma = color_update->gamma.state; MetaGammaLut *gamma = color_update->gamma.state;
struct drm_color_lut drm_color_lut[gamma->size]; g_autofree struct drm_color_lut *drm_color_lut = NULL;
int i; int i;
uint32_t color_lut_blob_id; uint32_t color_lut_blob_id;
drm_color_lut = g_new (struct drm_color_lut, gamma->size);
for (i = 0; i < gamma->size; i++) for (i = 0; i < gamma->size; i++)
{ {
drm_color_lut[i].red = gamma->red[i]; drm_color_lut[i].red = gamma->red[i];