brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

don't allow shade/maximize/minimize for windows that don't support those

Browse Source 
2001-10-07  Havoc Pennington  <hp@pobox.com>

	* src/window.c (meta_window_client_message): don't allow
	shade/maximize/minimize for windows that don't support those
	operations. (minimizing the panel = bad)
This commit is contained in:
Havoc Pennington 2001-10-07 22:11:13 +00:00 committed by Havoc Pennington
parent 350ecb1dcf
commit ec4dfd0cbc
4 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ChangeLog
View File

@ -1,3 +1,9 @@
2001-10-07 Havoc Pennington <hp@pobox.com>
* src/window.c (meta_window_client_message): don't allow
shade/maximize/minimize for windows that don't support those
operations. (minimizing the panel = bad)
2001-10-04 Havoc Pennington <hp@pobox.com> 2001-10-04 Havoc Pennington <hp@pobox.com>
* src/keybindings.c (meta_change_keygrab): add code to grab all * src/keybindings.c (meta_change_keygrab): add code to grab all

2
src/keybindings.c
View File

@ -194,7 +194,7 @@ meta_change_keygrab (MetaDisplay *display,
if (grab && result != Success) if (grab && result != Success)
{ {
const char *name; const char *name;
name = XKeysymToString (keysym); name = XKeysymToString (keysym);
if (name == NULL) if (name == NULL)
name = "(unknown)"; name = "(unknown)";

4
src/menu.c
View File

@ -257,10 +257,10 @@ meta_window_menu_new (MetaFrames *frames,
MenuData *md; MenuData *md;
if (ops & META_MENU_OP_UNSTICK) if (ops & META_MENU_OP_UNSTICK)
label = g_strdup_printf (_("Only on workspace _%d\n"), label = g_strdup_printf (_("Only on workspace _%d"),
i + 1); i + 1);
else else
label = g_strdup_printf (_("Move to workspace _%d\n"), label = g_strdup_printf (_("Move to workspace _%d"),
i + 1); i + 1);
mi = gtk_menu_item_new_with_mnemonic (label); mi = gtk_menu_item_new_with_mnemonic (label);

9
src/window.c
View File

@ -2287,7 +2287,7 @@ meta_window_client_message (MetaWindow *window,
shade = (action == _NET_WM_STATE_ADD || shade = (action == _NET_WM_STATE_ADD ||
(action == _NET_WM_STATE_TOGGLE && !window->shaded)); (action == _NET_WM_STATE_TOGGLE && !window->shaded));
if (shade) if (shade && window->has_shade_func)
meta_window_shade (window); meta_window_shade (window);
else else
meta_window_unshade (window); meta_window_unshade (window);
@ -2302,7 +2302,7 @@ meta_window_client_message (MetaWindow *window,
max = (action == _NET_WM_STATE_ADD || max = (action == _NET_WM_STATE_ADD ||
(action == _NET_WM_STATE_TOGGLE && !window->maximized)); (action == _NET_WM_STATE_TOGGLE && !window->maximized));
if (max) if (max && window->has_maximize_func)
meta_window_maximize (window); meta_window_maximize (window);
else else
meta_window_unmaximize (window); meta_window_unmaximize (window);
@ -2346,7 +2346,8 @@ meta_window_client_message (MetaWindow *window,
{ {
meta_verbose ("WM_CHANGE_STATE client message, state: %ld\n", meta_verbose ("WM_CHANGE_STATE client message, state: %ld\n",
event->xclient.data.l[0]); event->xclient.data.l[0]);
if (event->xclient.data.l[0] == IconicState) if (event->xclient.data.l[0] == IconicState &&
window->has_minimize_func)
meta_window_minimize (window); meta_window_minimize (window);
return TRUE; return TRUE;
@ -3549,7 +3550,7 @@ get_cardinal (MetaDisplay *display,
return FALSE; return FALSE;
if (type != XA_CARDINAL) if (type != XA_CARDINAL)
return FALSE; return FALSE; /* FIXME free num ? */
*val = *num; *val = *num;