From e0b74fee5219f9704d51c70dd3e5eaa0f43755a2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20=C3=85dahl?= Date: Mon, 30 Dec 2024 16:04:18 +0100 Subject: [PATCH] display: Replace X11 timestamp checking warnings with debug logs It's cases where some client is at fault, so don't print warnings in the journal unless asked to. Part-of: --- src/core/display.c | 29 ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/src/core/display.c b/src/core/display.c index 17f0c9c3e..cdb023990 100644 --- a/src/core/display.c +++ b/src/core/display.c @@ -2447,11 +2447,12 @@ meta_display_sanity_check_timestamps (MetaDisplay *display, { if (XSERVER_TIME_IS_BEFORE (timestamp, display->last_focus_time)) { - meta_warning ("last_focus_time (%u) is greater than comparison " - "timestamp (%u). This most likely represents a buggy " - "client sending inaccurate timestamps in messages such as " - "_NET_ACTIVE_WINDOW. Trying to work around...", - display->last_focus_time, timestamp); + meta_topic (META_DEBUG_X11, + "last_focus_time (%u) is greater than comparison " + "timestamp (%u). This most likely represents a buggy " + "client sending inaccurate timestamps in messages such as " + "_NET_ACTIVE_WINDOW. Trying to work around...", + display->last_focus_time, timestamp); display->last_focus_time = timestamp; } if (XSERVER_TIME_IS_BEFORE (timestamp, display->last_user_time)) @@ -2459,11 +2460,12 @@ meta_display_sanity_check_timestamps (MetaDisplay *display, GSList *windows; GSList *tmp; - meta_warning ("last_user_time (%u) is greater than comparison " - "timestamp (%u). This most likely represents a buggy " - "client sending inaccurate timestamps in messages such as " - "_NET_ACTIVE_WINDOW. Trying to work around...", - display->last_user_time, timestamp); + meta_topic (META_DEBUG_X11, + "last_user_time (%u) is greater than comparison " + "timestamp (%u). This most likely represents a buggy " + "client sending inaccurate timestamps in messages such as " + "_NET_ACTIVE_WINDOW. Trying to work around...", + display->last_user_time, timestamp); display->last_user_time = timestamp; windows = meta_display_list_windows (display, META_LIST_DEFAULT); @@ -2474,9 +2476,10 @@ meta_display_sanity_check_timestamps (MetaDisplay *display, if (XSERVER_TIME_IS_BEFORE (timestamp, window->net_wm_user_time)) { - meta_warning ("%s appears to be one of the offending windows " - "with a timestamp of %u. Working around...", - window->desc, window->net_wm_user_time); + meta_topic (META_DEBUG_X11, + "%s appears to be one of the offending windows " + "with a timestamp of %u. Working around...", + window->desc, window->net_wm_user_time); window->net_wm_user_time_set = FALSE; meta_window_set_user_time (window, timestamp); }