brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

window: Really propagate effective on-all-workspaces setting to transients

Browse Source 
Commit cda9579034 fixed a corner case when setting the initial workspace
state of transient windows, but it still missed a case:

should_be_on_all_workspaces() returns whether the window should be on all
workspaces according to its properties/placement, but it doesn't take
transient relations into account.

That means in case of nested transients, we can still fail the assert:

 1. on-all-workspaces toplevel
 2. should_be_on_all_workspaces() is TRUE for the first transient's parent,
    as the window from (1) has on_all_workspaces_requested == TRUE
 3. should_be_on_all_workspaces() is FALSE for the second transient's
    parent, as the window from (2) is only on-all-workspace because
    of its parent

We can fix this by either using the state from the root ancestor
instead of the direct transient parent, or by using the parent's
on_all_workspaces_state.

The latter is simpler, so go with that.

https://gitlab.gnome.org/GNOME/mutter/issues/1083
This commit is contained in:
Florian Müllner 2020-03-21 18:24:52 +01:00 committed by Jonas Ådahl
parent d052f9c070
commit d4c070da88
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/window.c
View File

@ -1319,7 +1319,7 @@ _meta_window_shared_new (MetaDisplay *display,
g_warn_if_fail (!window->transient_for->override_redirect); g_warn_if_fail (!window->transient_for->override_redirect);
set_workspace_state (window, set_workspace_state (window,
should_be_on_all_workspaces (window->transient_for), window->transient_for->on_all_workspaces,
window->transient_for->workspace); window->transient_for->workspace);
} }
else if (window->on_all_workspaces) else if (window->on_all_workspaces)