From d2f1edd6c6aec4f5c6248d380de77ce6896b0ff0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jonas=20=C3=85dahl?= <jadahl@gmail.com>
Date: Fri, 8 Feb 2019 19:42:06 +0100
Subject: [PATCH] wayland/surface: Process damage also for non-actor surfaces

The texture still needs to be updated with damaged content.

https://gitlab.gnome.org/GNOME/mutter/issues/199
---
 src/wayland/meta-wayland-surface.c | 30 ++++++++++++++++--------------
 1 file changed, 16 insertions(+), 14 deletions(-)

diff --git a/src/wayland/meta-wayland-surface.c b/src/wayland/meta-wayland-surface.c
index 2351fedab..ccdbdf4ae 100644
--- a/src/wayland/meta-wayland-surface.c
+++ b/src/wayland/meta-wayland-surface.c
@@ -283,7 +283,7 @@ surface_process_damage (MetaWaylandSurface *surface,
   cairo_region_t *transformed_region;
   cairo_region_t *viewport_region;
   ClutterRect src_rect;
-  int i, n_rectangles;
+  MetaSurfaceActor *actor;
 
   /* If the client destroyed the buffer it attached before committing, but
    * still posted damage, or posted damage without any buffer, don't try to
@@ -345,18 +345,21 @@ surface_process_damage (MetaWaylandSurface *surface,
   /* First update the buffer. */
   meta_wayland_buffer_process_damage (buffer, buffer_region);
 
-  /* Now damage the actor. The actor expects damage in the unscaled texture
-   * coordinate space, i.e. same as the buffer. */
-  /* XXX: Should this be a signal / callback on MetaWaylandBuffer instead? */
-  n_rectangles = cairo_region_num_rectangles (buffer_region);
-  for (i = 0; i < n_rectangles; i++)
+  actor = meta_wayland_surface_get_actor (surface);
+  if (actor)
     {
-      cairo_rectangle_int_t rect;
-      cairo_region_get_rectangle (buffer_region, i, &rect);
+      int i, n_rectangles;
 
-      meta_surface_actor_process_damage (meta_wayland_surface_get_actor (surface),
-                                         rect.x, rect.y,
-                                         rect.width, rect.height);
+      n_rectangles = cairo_region_num_rectangles (buffer_region);
+      for (i = 0; i < n_rectangles; i++)
+        {
+          cairo_rectangle_int_t rect;
+          cairo_region_get_rectangle (buffer_region, i, &rect);
+
+          meta_surface_actor_process_damage (actor,
+                                             rect.x, rect.y,
+                                             rect.width, rect.height);
+        }
     }
 
   cairo_region_destroy (viewport_region);
@@ -774,9 +777,8 @@ meta_wayland_surface_apply_pending_state (MetaWaylandSurface      *surface,
       surface->viewport.has_dst_size = surface->viewport.dst_width > 0;
     }
 
-  if (meta_wayland_surface_get_actor (surface) &&
-      (!cairo_region_is_empty (pending->surface_damage) ||
-       !cairo_region_is_empty (pending->buffer_damage)))
+  if (!cairo_region_is_empty (pending->surface_damage) ||
+      !cairo_region_is_empty (pending->buffer_damage))
     surface_process_damage (surface,
                             pending->surface_damage,
                             pending->buffer_damage);