I was using meta_workspace_contains_window() in a number of places where

2001-10-25  Havoc Pennington  <hp@pobox.com>

	* src/window.c (meta_window_visible_on_workspace):
	I was using meta_workspace_contains_window() in a number of
	places where on_all_workspaces should also have been considered,
	thus this new function. Fixes bugs such as pinned windows
	not appearing in the tab order.
	(meta_window_client_message): use meta_window_visible_on_workspace

	* src/stack.c (find_tab_forward): ditto
	(find_tab_backward): ditto
	(meta_stack_get_tab_next): ditto
	(meta_stack_get_tab_list): ditto

	* src/place.c (get_windows_on_same_workspace): ditto

	* src/keybindings.c (handle_focus_previous): ditto
	(handle_focus_previous): ditto
This commit is contained in:
Havoc Pennington
2001-10-25 04:51:25 +00:00
committed by Havoc Pennington
parent bacc9c0afc
commit d080f816b6
7 changed files with 48 additions and 20 deletions

View File

@@ -894,7 +894,7 @@ find_tab_forward (MetaStack *stack,
if (window && IN_TAB_CHAIN (window) &&
(workspace == NULL ||
meta_workspace_contains_window (workspace, window)))
meta_window_visible_on_workspace (window, workspace)))
return window;
++i;
@@ -910,7 +910,7 @@ find_tab_forward (MetaStack *stack,
if (window && IN_TAB_CHAIN (window) &&
(workspace == NULL ||
meta_workspace_contains_window (workspace, window)))
meta_window_visible_on_workspace (window, workspace)))
return window;
++i;
@@ -939,7 +939,7 @@ find_tab_backward (MetaStack *stack,
if (window && IN_TAB_CHAIN (window) &&
(workspace == NULL ||
meta_workspace_contains_window (workspace, window)))
meta_window_visible_on_workspace (window, workspace)))
return window;
--i;
@@ -955,7 +955,7 @@ find_tab_backward (MetaStack *stack,
if (window && IN_TAB_CHAIN (window) &&
(workspace == NULL ||
meta_workspace_contains_window (workspace, window)))
meta_window_visible_on_workspace (window, workspace)))
return window;
--i;
@@ -980,7 +980,7 @@ meta_stack_get_tab_next (MetaStack *stack,
* you get a key shortcut or something on a window just as you
* are moving workspaces to one the window isn't on
*/
if (!meta_workspace_contains_window (workspace, window))
if (!meta_window_visible_on_workspace (window, workspace))
return NULL;
}
@@ -1037,7 +1037,7 @@ meta_stack_get_tab_list (MetaStack *stack,
if (window && IN_TAB_CHAIN (window) &&
(workspace == NULL ||
meta_workspace_contains_window (workspace, window)))
meta_window_visible_on_workspace (window, workspace)))
list = g_slist_prepend (list, window);
++i;