Add a workaround for slow read pixels on Mesa
Mesa before version 8.0.2 has a slow read pixels path that gets used with the Intel driver where it converts all of the pixels into a floating point representation and back even if the data is being read into exactly the same format. There is however a faster path using the blitter when reading into a PBO with BGRA format. It works out faster to read into a PBO and then memcpy back out into the application's buffer even though it adds an extra memcpy. This patch adds a workaround in cogl_framebuffer_read_pixels_into_bitmap when it detects this situation. In that case it will create a temporary CoglBitmap using cogl_bitmap_new_with_size, read into it and then memcpy the data back out. The main impetus for this patch is that Gnome Shell has implemented this workaround directly using GL calls but it seems like the kind of thing that would sit better at the Cogl layer. Reviewed-by: Robert Bragg <robert@linux.intel.com>
This commit is contained in:
@ -93,6 +93,16 @@ typedef enum _CoglFramebufferState
|
||||
|
||||
#define COGL_FRAMEBUFFER_STATE_ALL ((1<<COGL_FRAMEBUFFER_STATE_INDEX_MAX) - 1)
|
||||
|
||||
/* Private flags that can internally be added to CoglReadPixelsFlags */
|
||||
typedef enum
|
||||
{
|
||||
/* If this is set then the data will not be flipped to compensate
|
||||
for GL's upside-down coordinate system but instead will be left
|
||||
in whatever order GL gives us (which will depend on whether the
|
||||
framebuffer is offscreen or not) */
|
||||
COGL_READ_PIXELS_NO_FLIP = 1L << 30
|
||||
} CoglPrivateReadPixelsFlags;
|
||||
|
||||
struct _CoglFramebuffer
|
||||
{
|
||||
CoglObject _parent;
|
||||
|
Reference in New Issue
Block a user