brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

keybindings: Small code cleanup

Browse Source 
Reuse the name we just set to insert in the hash table, that avoids
duplicating the string.

Suggested-by: Carlos Garnacho <carlosg@gnome.org>

https://gitlab.gnome.org/GNOME/mutter/merge_requests/453
This commit is contained in:
Olivier Fourdan 2019-05-16 10:58:27 +02:00 committed by Carlos Garnacho
parent 851b7d0639
commit c53aa89098
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/core/keybindings.c
View File

@ -4455,26 +4455,26 @@ meta_display_init_keys (MetaDisplay *display)
handler->name = g_strdup ("overlay-key"); handler->name = g_strdup ("overlay-key");
handler->flags = META_KEY_BINDING_BUILTIN; handler->flags = META_KEY_BINDING_BUILTIN;
g_hash_table_insert (key_handlers, g_strdup ("overlay-key"), handler); g_hash_table_insert (key_handlers, g_strdup (handler->name), handler);
handler = g_new0 (MetaKeyHandler, 1); handler = g_new0 (MetaKeyHandler, 1);
handler->name = g_strdup ("locate-pointer-key"); handler->name = g_strdup ("locate-pointer-key");
handler->flags = META_KEY_BINDING_BUILTIN; handler->flags = META_KEY_BINDING_BUILTIN;
g_hash_table_insert (key_handlers, g_strdup ("locate-pointer-key"), handler); g_hash_table_insert (key_handlers, g_strdup (handler->name), handler);
handler = g_new0 (MetaKeyHandler, 1); handler = g_new0 (MetaKeyHandler, 1);
handler->name = g_strdup ("iso-next-group"); handler->name = g_strdup ("iso-next-group");
handler->flags = META_KEY_BINDING_BUILTIN; handler->flags = META_KEY_BINDING_BUILTIN;
g_hash_table_insert (key_handlers, g_strdup ("iso-next-group"), handler); g_hash_table_insert (key_handlers, g_strdup (handler->name), handler);
handler = g_new0 (MetaKeyHandler, 1); handler = g_new0 (MetaKeyHandler, 1);
handler->name = g_strdup ("external-grab"); handler->name = g_strdup ("external-grab");
handler->func = handle_external_grab; handler->func = handle_external_grab;
handler->default_func = handle_external_grab; handler->default_func = handle_external_grab;
g_hash_table_insert (key_handlers, g_strdup ("external-grab"), handler); g_hash_table_insert (key_handlers, g_strdup (handler->name), handler);
external_grabs = g_hash_table_new_full (g_str_hash, g_str_equal, external_grabs = g_hash_table_new_full (g_str_hash, g_str_equal,
NULL, NULL,

4
src/core/prefs.c
View File

@ -1728,7 +1728,7 @@ init_bindings (void)
pref->combos = g_slist_prepend (pref->combos, &overlay_key_combo); pref->combos = g_slist_prepend (pref->combos, &overlay_key_combo);
pref->builtin = 1; pref->builtin = 1;
g_hash_table_insert (key_bindings, g_strdup ("overlay-key"), pref); g_hash_table_insert (key_bindings, g_strdup (pref->name), pref);
pref = g_new0 (MetaKeyPref, 1); pref = g_new0 (MetaKeyPref, 1);
pref->name = g_strdup ("locate-pointer-key"); pref->name = g_strdup ("locate-pointer-key");
@ -1736,7 +1736,7 @@ init_bindings (void)
pref->combos = g_slist_prepend (pref->combos, &locate_pointer_key_combo); pref->combos = g_slist_prepend (pref->combos, &locate_pointer_key_combo);
pref->builtin = 1; pref->builtin = 1;
g_hash_table_insert (key_bindings, g_strdup ("locate-pointer-key"), pref); g_hash_table_insert (key_bindings, g_strdup (pref->name), pref);
} }
static gboolean static gboolean