brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unused public window-property functions

Browse Source 
Simplify the set of window-property functions to remove the
unused functions:

 meta_window_reload_properties_from_xwindow()
 meta_window_reload_properties()

And to make:

 meta_window_reload_property()

static. The code is considerably simplified by removing the
plural variants.

https://bugzilla.gnome.org/show_bug.cgi?id=587255
This commit is contained in:
Owen W. Taylor 2009-06-28 18:32:27 -04:00
parent 7938458eb8
commit c02e1b6f56
2 changed files with 29 additions and 114 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

76
src/core/window-props.c
View File

@ -77,75 +77,39 @@ static MetaWindowPropHooks* find_hooks (MetaDisplay *display,
Atom property);
void
meta_window_reload_property (MetaWindow *window,
Atom property,
gboolean initial)
{
meta_window_reload_properties (window, &property, 1, initial);
}
void
meta_window_reload_properties (MetaWindow *window,
const Atom *properties,
int n_properties,
gboolean initial)
{
meta_window_reload_properties_from_xwindow (window,
window->xwindow,
properties,
n_properties,
initial);
}
void
meta_window_reload_property_from_xwindow (MetaWindow *window,
Window xwindow,
Atom property,
gboolean initial)
{
meta_window_reload_properties_from_xwindow (window, xwindow, &property, 1,
initial);
}
MetaPropValue value = { 0, };
MetaWindowPropHooks *hooks;
void
meta_window_reload_properties_from_xwindow (MetaWindow *window,
Window xwindow,
const Atom *properties,
int n_properties,
gboolean initial)
{
int i;
MetaPropValue *values;
hooks = find_hooks (window->display, property);
if (!hooks)
return;
g_return_if_fail (properties != NULL);
g_return_if_fail (n_properties > 0);
values = g_new0 (MetaPropValue, n_properties);
i = 0;
while (i < n_properties)
{
MetaWindowPropHooks *hooks = find_hooks (window->display, properties[i]);
init_prop_value (window, hooks, &values[i]);
++i;
}
init_prop_value (window, hooks, &value);
meta_prop_get_values (window->display, xwindow,
values, n_properties);
&value, 1);
i = 0;
while (i < n_properties)
{
MetaWindowPropHooks *hooks = find_hooks (window->display, properties[i]);
reload_prop_value (window, hooks, &values[i], initial);
reload_prop_value (window, hooks, &value,
initial);
++i;
}
meta_prop_free_values (&value, 1);
}
meta_prop_free_values (values, n_properties);
g_free (values);
static void
meta_window_reload_property (MetaWindow *window,
Atom property,
gboolean initial)
{
meta_window_reload_property_from_xwindow (window,
window->xwindow,
property,
initial);
}
void

51
src/core/window-props.h
View File

@ -35,35 +35,6 @@
#include "window-private.h"
/**
* meta_window_reload_property:
* @window: The window.
* @property: A single X atom.
*
* Requests the current values of a single property for a given
* window from the server, and deals with it appropriately.
* Does not return it to the caller (it's been dealt with!)
*/
void meta_window_reload_property (MetaWindow *window,
Atom property,
gboolean initial);
/**
* meta_window_reload_properties:
* @window: The window.
* @properties: A pointer to a list of X atoms, "n_properties" long.
* @n_properties: The length of the properties list.
*
* Requests the current values of a set of properties for a given
* window from the server, and deals with them appropriately.
* Does not return them to the caller (they've been dealt with!)
*/
void meta_window_reload_properties (MetaWindow *window,
const Atom *properties,
int n_properties,
gboolean initial);
/**
* meta_window_reload_property_from_xwindow:
* @window: A window on the same display as the one we're
@ -75,31 +46,11 @@ void meta_window_reload_properties (MetaWindow *window,
* window from the server, and deals with it appropriately.
* Does not return it to the caller (it's been dealt with!)
*/
void meta_window_reload_property_from_xwindow
(MetaWindow *window,
void meta_window_reload_property_from_xwindow (MetaWindow *window,
Window xwindow,
Atom property,
gboolean initial);
/**
* meta_window_reload_properties_from_xwindow:
* @window: A window on the same display as the one we're
* investigating (only used to find the display)
* @xwindow: The X handle for the window.
* @properties: A pointer to a list of X atoms, "n_properties" long.
* @n_properties: The length of the properties list.
*
* Requests the current values of a set of properties for a given
* window from the server, and deals with them appropriately.
* Does not return them to the caller (they've been dealt with!)
*/
void meta_window_reload_properties_from_xwindow
(MetaWindow *window,
Window xwindow,
const Atom *properties,
int n_properties,
gboolean initial);
/**
* meta_window_load_initial_properties:
* @window: The window.