From bfc87d13cb0e101ffc351e535a3565a97f2282b5 Mon Sep 17 00:00:00 2001 From: Giovanni Campagna Date: Sat, 17 Aug 2013 15:51:33 +0200 Subject: [PATCH] MetaWindowActor: fix reference counting issue We need to use g_signal_connect_object(), rather than g_signal_connect(), because the window actor can be destroyed before the window emits the final notify::appears-focused inside unmanage, if the plugin decides that it doesn't want to animate the destruction (which happens with dialogs and the default plugin) https://bugzilla.gnome.org/show_bug.cgi?id=706207 --- src/compositor/meta-window-actor.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/compositor/meta-window-actor.c b/src/compositor/meta-window-actor.c index 0e233db62..f7d61f6ef 100644 --- a/src/compositor/meta-window-actor.c +++ b/src/compositor/meta-window-actor.c @@ -392,10 +392,10 @@ meta_window_actor_constructed (GObject *object) */ g_object_ref (priv->actor); - g_signal_connect (window, "notify::decorated", - G_CALLBACK (window_decorated_notify), self); - g_signal_connect (window, "notify::appears-focused", - G_CALLBACK (window_appears_focused_notify), self); + g_signal_connect_object (window, "notify::decorated", + G_CALLBACK (window_decorated_notify), self, 0); + g_signal_connect_object (window, "notify::appears-focused", + G_CALLBACK (window_appears_focused_notify), self, 0); } else {