From af9a7741f430fea5e7f0874c93a3ccc9f01cae3b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20=C3=85dahl?= Date: Sat, 4 Mar 2023 23:52:57 +0100 Subject: [PATCH] frames: Select SubstructureNotifyMask too This is the mask that lets us receive among other events the rather important CreateNotify, that tells us about new winows. This has went by rather unnoticed except for cases where multiple windows show up very quickly directly after the frames client spawned, because the drag icon surface cache eventually already did select that particular mask. Make things more reliably by explicitly setting the mask for the events we rely on to function. This fixes flaky stacking tests that map multiple X11 windows in a row. Part-of: --- src/frames/meta-window-tracker.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/frames/meta-window-tracker.c b/src/frames/meta-window-tracker.c index 56be33790..39de518f6 100644 --- a/src/frames/meta-window-tracker.c +++ b/src/frames/meta-window-tracker.c @@ -340,7 +340,8 @@ meta_window_tracker_constructed (GObject *object) XSelectInput (xdisplay, xroot, KeyPressMask | - PropertyChangeMask); + PropertyChangeMask | + SubstructureNotifyMask); g_signal_connect (display, "xevent", G_CALLBACK (on_xevent), object);