2007-07-28 Emmanuele Bassi <ebassi@openedhand.com>

* clutter/clutter-actor.[ch]: Use GInitiallyUnowned
	as the parent structure in the ClutterActor structure
	definition; somehow, this has escaped everyone attention
	in one year and a half. Luckily, GInitiallyUnowned is
	as big as GObject.
	 
	 (clutter_actor_get_abs_position_units),
	 (clutter_actor_get_abs_position): Check parameters.

	 * clutter/clutter-texture.h: Unmangle the flags enum
	 type declaration, so that dumb parsers like h2defs.py
	 are not fooled.

	 * clutter/clutter-behaviour-ellipse.[ch]:
	 * clutter/clutter-effect.c: Fix some documentation
	 issues and make gtk-doc happy.

ChangeLog

@@ -1,3 +1,22 @@
+2007-07-28  Emmanuele Bassi  <ebassi@openedhand.com>
+
+	* clutter/clutter-actor.[ch]: Use GInitiallyUnowned
+	as the parent structure in the ClutterActor structure
+	definition; somehow, this has escaped everyone attention
+	in one year and a half. Luckily, GInitiallyUnowned is
+	as big as GObject.
+	 
+	 (clutter_actor_get_abs_position_units),
+	 (clutter_actor_get_abs_position): Check parameters.
+
+	 * clutter/clutter-texture.h: Unmangle the flags enum
+	 type declaration, so that dumb parsers like h2defs.py
+	 are not fooled.
+
+	 * clutter/clutter-behaviour-ellipse.[ch]:
+	 * clutter/clutter-effect.c: Fix some documentation
+	 issues and make gtk-doc happy.
+
 2007-07-27  Tomas Frydrych  <tf@openedhand.com>
 
 	* clutter/clutter-behaviour-ellipse.h:

clutter/clutter-actor.c

@@ -1431,12 +1431,16 @@ clutter_actor_get_abs_position_units (ClutterActor *self,
 {
   ClutterVertex v1;
   ClutterVertex v2;
+
+  g_return_if_fail (CLUTTER_IS_ACTOR (self));
   
   v1.x = v1.y = v1.z = 0;
   clutter_actor_apply_transform_to_point (self, &v1, &v2);
 
-  *x = v2.x;
+  if (x)
-  *y = v2.y;
+    *x = v2.x;
+  if (y)
+    *y = v2.y;
 }
 
 /**
@@ -1450,14 +1454,20 @@ clutter_actor_get_abs_position_units (ClutterActor *self,
  */
 void
 clutter_actor_get_abs_position (ClutterActor *self,
-				gint           *x,
+				gint         *x,
-				gint           *y)
+				gint         *y)
 {
-  gint32 xu, yu;
+  ClutterUnit xu, yu;
+
+  g_return_if_fail (CLUTTER_IS_ACTOR (self));
+
+  xu = yu = 0;
   clutter_actor_get_abs_position_units (self, &xu, &yu);
 
-  *x = CLUTTER_UNITS_TO_INT (xu);
+  if (x)
-  *y = CLUTTER_UNITS_TO_INT (yu);
+    *x = CLUTTER_UNITS_TO_INT (xu);
+  if (y)
+    *y = CLUTTER_UNITS_TO_INT (yu);
 }
 
 /*

clutter/clutter-actor.h

@@ -111,7 +111,7 @@ GType clutter_actor_box_get_type (void) G_GNUC_CONST;
 struct _ClutterActor
 {
   /*< private >*/
-  GObject parent_instance;
+  GInitiallyUnowned parent_instance;
   
   /*< public >*/
   guint32 flags;
@@ -124,7 +124,7 @@ struct _ClutterActor
 
 struct _ClutterActorClass
 {
-  GObjectClass parent_class;
+  GInitiallyUnownedClass parent_class;
 
   void (* show)            (ClutterActor        *actor);
   void (* show_all)        (ClutterActor        *actor);

clutter/clutter-behaviour-ellipse.c

@@ -992,7 +992,7 @@ clutter_behaviour_ellipse_get_angle_tilt (ClutterBehaviourEllipse *self,
 /**
  * clutter_behaviour_ellipse_get_angle_tiltx
  * @self: a #ClutterBehaviourEllipse
- * @self: a #ClutterRotateAxis
+ * @axis: a #ClutterRotateAxis
  *
  * Gets the tilt of the ellipse around the center in the given axis.
  *

clutter/clutter-behaviour-ellipse.h

@@ -135,18 +135,18 @@ ClutterAngle           clutter_behaviour_ellipse_get_angle_endx     (ClutterBeha
 gdouble                clutter_behaviour_ellipse_get_angle_end      (ClutterBehaviourEllipse    *self);
 
 void                   clutter_behaviour_ellipse_set_angle_tiltx    (ClutterBehaviourEllipse    *self,
-								     ClutterRotateAxis,
+								     ClutterRotateAxis           axis,
 								     ClutterAngle                angle_tilt);
 
 void                   clutter_behaviour_ellipse_set_angle_tilt     (ClutterBehaviourEllipse    *self,
-								     ClutterRotateAxis,
+								     ClutterRotateAxis           axis,
 								     gdouble                     angle_tilt);
 
 ClutterAngle           clutter_behaviour_ellipse_get_angle_tiltx    (ClutterBehaviourEllipse    *self,
-								     ClutterRotateAxis);
+								     ClutterRotateAxis           axis);
 
 gdouble                clutter_behaviour_ellipse_get_angle_tilt     (ClutterBehaviourEllipse    *self,
-								     ClutterRotateAxis);
+								     ClutterRotateAxis           axis);
 
 void                   clutter_behaviour_ellipse_set_tilt           (ClutterBehaviourEllipse    *self,
 								     gdouble                     angle_tilt_x,

clutter/clutter-effect.c

@@ -657,7 +657,7 @@ clutter_effect_rotate_y (ClutterEffectTemplate     *template_,
 }
 
 /**
- * clutter_effect_rotate_y:
+ * clutter_effect_rotate_z:
  * @template_: A #ClutterEffectTemplate
  * @actor: A #ClutterActor to apply the effect to.
  * @angle_begin: Initial angle to apply to actor

clutter/clutter-texture.h

@@ -75,11 +75,11 @@ struct _ClutterTextureClass
   void (*_clutter_texture6) (void);
 };
 
-typedef enum ClutterTextureFlags
+typedef enum { /*< prefix=CLUTTER_TEXTURE >*/
-{
+    CLUTTER_TEXTURE_RGB_FLAG_BGR     = 1 << 1,
-    CLUTTER_TEXTURE_RGB_FLAG_BGR     = (1 << 1),
+    CLUTTER_TEXTURE_RGB_FLAG_PREMULT = 1 << 2, /* FIXME: not handled */
-    CLUTTER_TEXTURE_RGB_FLAG_PREMULT = (1 << 2), /* FIXME: not handled */
+    CLUTTER_TEXTURE_YUV_FLAG_YUV2    = 1 << 3
-    CLUTTER_TEXTURE_YUV_FLAG_YUV2    = (1 << 3)
+
     /* FIXME: add compressed types ? */
 } ClutterTextureFlags;