From aad237a04ada9ff0f7ceaea55a5c70bf281e7abc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20=C3=85dahl?= Date: Thu, 12 Dec 2024 00:42:42 +0100 Subject: [PATCH] renderer/native: Don't close DMA buf fds before handing them forward We closed all the DMA buffer fds after creating the DMA buffer backed CoglFramebuffer, which meant that the fds we passed to CoglDmaBufHandle were already closed. This broke screen casting with DMA buffers. Fixes: 8509b74532 ("Make DMA buffer allocation format and modifier aware") Part-of: --- src/backends/native/meta-renderer-native.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backends/native/meta-renderer-native.c b/src/backends/native/meta-renderer-native.c index ec1c19347..b6d55a13d 100644 --- a/src/backends/native/meta-renderer-native.c +++ b/src/backends/native/meta-renderer-native.c @@ -1089,11 +1089,11 @@ meta_renderer_native_create_dma_buf (CoglRenderer *cogl_renderer, offsets, plane_modifiers, error); - - close_fds (fds, n_planes); - if (!dmabuf_fb) - return NULL; + { + close_fds (fds, n_planes); + return NULL; + } dmabuf_handle = cogl_dma_buf_handle_new (dmabuf_fb,