From a075f4498b3c49d7a349bec09758af2c2be67aaf Mon Sep 17 00:00:00 2001 From: Neil Roberts Date: Wed, 11 May 2011 13:50:32 +0100 Subject: [PATCH] cogl-pipeline-fragend-arbfp: Fix the comparison for dot3 arguments There was a typo in fragend_arbfp_args_equal so that it wasn't comparing the constants correctly. Thomas Wood found this bug with static analysis. --- cogl/cogl-pipeline-fragend-arbfp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cogl/cogl-pipeline-fragend-arbfp.c b/cogl/cogl-pipeline-fragend-arbfp.c index 4e14ba1ce..18f855362 100644 --- a/cogl/cogl-pipeline-fragend-arbfp.c +++ b/cogl/cogl-pipeline-fragend-arbfp.c @@ -558,7 +558,7 @@ fragend_arbfp_args_equal (CoglPipelineFragendARBfpArg *arg0, * have one target enabled at a time. */ if (arg0->type == COGL_PIPELINE_FRAGEND_ARBFP_ARG_TYPE_CONSTANT && - arg0->constant_id != arg0->constant_id) + arg0->constant_id != arg1->constant_id) return FALSE; if (arg0->swizzle != arg1->swizzle &&