brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

wayland: Ensure to remove destroy listener for MetaWaylandBuffer

Browse Source 
Avoid the chance of invalid memory access by leaving the wl_listener
behind when handling the destroy notification.

Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2588>
This commit is contained in:
Carlos Garnacho 2022-08-19 17:13:01 +02:00 committed by Marge Bot
parent f4f39d3a2c
commit 9c402bd091
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/wayland/meta-wayland-buffer.c
View File

@ -83,12 +83,13 @@ G_DEFINE_TYPE (MetaWaylandBuffer, meta_wayland_buffer, G_TYPE_OBJECT);
static void static void
meta_wayland_buffer_destroy_handler (struct wl_listener *listener, meta_wayland_buffer_destroy_handler (struct wl_listener *listener,
void *data) void *data)
{ {
MetaWaylandBuffer *buffer = MetaWaylandBuffer *buffer =
wl_container_of (listener, buffer, destroy_listener); wl_container_of (listener, buffer, destroy_listener);
buffer->resource = NULL; buffer->resource = NULL;
wl_list_remove (&buffer->destroy_listener.link);
g_signal_emit (buffer, signals[RESOURCE_DESTROYED], 0); g_signal_emit (buffer, signals[RESOURCE_DESTROYED], 0);
g_object_unref (buffer); g_object_unref (buffer);
} }