2007-11-20 Emmanuele Bassi <ebassi@openedhand.com>

* clutter/clutter-actor.c::
	* clutter/clutter-behaviour-opacity.c:
	* clutter/clutter-clone-texture.c:
	* clutter/clutter-effect.c:
	* clutter/clutter-label.c: Remove the usage of G_PARAM_CONSTRUCT
	without an override for the ::construct virtual function; using
	G_PARAM_CONSTRUCT to set the default value of a property is not
	the recommended approach; default values are set inside the
	instance init function.
This commit is contained in:
Emmanuele Bassi 2007-11-20 16:05:56 +00:00
parent 6cb35639e7
commit 9955b06542
6 changed files with 21 additions and 10 deletions

View File

@ -1,3 +1,15 @@
2007-11-20 Emmanuele Bassi <ebassi@openedhand.com>
* clutter/clutter-actor.c::
* clutter/clutter-behaviour-opacity.c:
* clutter/clutter-clone-texture.c:
* clutter/clutter-effect.c:
* clutter/clutter-label.c: Remove the usage of G_PARAM_CONSTRUCT
without an override for the ::construct virtual function; using
G_PARAM_CONSTRUCT to set the default value of a property is not
the recommended approach; default values are set inside the
instance init function.
2007-11-20 Emmanuele Bassi <ebassi@openedhand.com> 2007-11-20 Emmanuele Bassi <ebassi@openedhand.com>
* clutter/clutter-texture.c (clutter_texture_init): Set filter-quality * clutter/clutter-texture.c (clutter_texture_init): Set filter-quality

View File

@ -1169,7 +1169,7 @@ clutter_actor_class_init (ClutterActorClass *klass)
"Opacity of actor", "Opacity of actor",
0, 0xff, 0, 0xff,
0xff, 0xff,
G_PARAM_CONSTRUCT | CLUTTER_PARAM_READWRITE)); CLUTTER_PARAM_READWRITE));
/** /**
* ClutterActor:visible: * ClutterActor:visible:
* *

View File

@ -175,9 +175,7 @@ clutter_behaviour_opacity_class_init (ClutterBehaviourOpacityClass *klass)
"Initial opacity level", "Initial opacity level",
0, 255, 0, 255,
0, 0,
CLUTTER_PARAM_READWRITE | CLUTTER_PARAM_READWRITE));
G_PARAM_CONSTRUCT));
/** /**
* ClutterBehaviourOpacity:opacity-end: * ClutterBehaviourOpacity:opacity-end:
* *
@ -192,8 +190,7 @@ clutter_behaviour_opacity_class_init (ClutterBehaviourOpacityClass *klass)
"Final opacity level", "Final opacity level",
0, 255, 0, 255,
0, 0,
CLUTTER_PARAM_READWRITE | CLUTTER_PARAM_READWRITE));
G_PARAM_CONSTRUCT));
behave_class->alpha_notify = clutter_behaviour_alpha_notify; behave_class->alpha_notify = clutter_behaviour_alpha_notify;
@ -204,6 +201,9 @@ static void
clutter_behaviour_opacity_init (ClutterBehaviourOpacity *self) clutter_behaviour_opacity_init (ClutterBehaviourOpacity *self)
{ {
self->priv = CLUTTER_BEHAVIOUR_OPACITY_GET_PRIVATE (self); self->priv = CLUTTER_BEHAVIOUR_OPACITY_GET_PRIVATE (self);
self->priv->opacity_start = 0;
self->priv->opacity_end = 0;
} }
/** /**

View File

@ -345,7 +345,7 @@ clutter_clone_texture_class_init (ClutterCloneTextureClass *klass)
"Parent Texture", "Parent Texture",
"The parent texture to clone", "The parent texture to clone",
CLUTTER_TYPE_TEXTURE, CLUTTER_TYPE_TEXTURE,
(G_PARAM_CONSTRUCT | CLUTTER_PARAM_READWRITE))); CLUTTER_PARAM_READWRITE));
g_type_class_add_private (gobject_class, sizeof (ClutterCloneTexturePrivate)); g_type_class_add_private (gobject_class, sizeof (ClutterCloneTexturePrivate));
} }

View File

@ -252,7 +252,6 @@ clutter_effect_template_class_init (ClutterEffectTemplateClass *klass)
"Clone", "Clone",
"controls if effects should clone or reference the templated timeline", "controls if effects should clone or reference the templated timeline",
TRUE, TRUE,
G_PARAM_CONSTRUCT |
CLUTTER_PARAM_READWRITE)); CLUTTER_PARAM_READWRITE));
} }

View File

@ -627,14 +627,14 @@ clutter_label_class_init (ClutterLabelClass *klass)
"Font Name", "Font Name",
"Pango font description", "Pango font description",
NULL, NULL,
G_PARAM_CONSTRUCT | CLUTTER_PARAM_READWRITE)); CLUTTER_PARAM_READWRITE));
g_object_class_install_property g_object_class_install_property
(gobject_class, PROP_TEXT, (gobject_class, PROP_TEXT,
g_param_spec_string ("text", g_param_spec_string ("text",
"Text", "Text",
"Text to render", "Text to render",
NULL, NULL,
G_PARAM_CONSTRUCT | CLUTTER_PARAM_READWRITE)); CLUTTER_PARAM_READWRITE));
g_object_class_install_property g_object_class_install_property
(gobject_class, PROP_COLOR, (gobject_class, PROP_COLOR,
g_param_spec_boxed ("color", g_param_spec_boxed ("color",