brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

renderer-native: Ensure all planes support EGL config format

Browse Source 
For secondary GPU rendering contexts we currently might choose an EGL
config with a format which is not supported on all primary planes. The
renderer is created when a GPU is detected and lighting up outputs and
thus assigning CRTC and primary planes can happen at any point after
that. This means we have to make sure that all possible plane
assignments will work with the rendering context when we create it.

Closes: https://gitlab.gnome.org/GNOME/mutter/-/issues/3235
Fixes: cc7bca073 ("crtc/kms: Dynamically assign primary and cursor planes")
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3512>
This commit is contained in:
Sebastian Wick 2024-01-10 15:19:55 +01:00 committed by Robert Mader
parent fbf68bf88c
commit 947f20b1a7
1 changed files with 32 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
src/backends/native/meta-renderer-native.c
View File

@ -1607,6 +1607,36 @@ meta_renderer_native_finish_frame (MetaRendererNative *renderer_native,
}
}
static gboolean
all_primary_planes_support_format (MetaCrtcKms *crtc_kms,
uint32_t drm_format)
{
MetaKmsCrtc *kms_crtc = meta_crtc_kms_get_kms_crtc (crtc_kms);
MetaKmsDevice *kms_device = meta_kms_crtc_get_device (kms_crtc);
gboolean supported = FALSE;
GList *l;
for (l = meta_kms_device_get_planes (kms_device); l; l = l->next)
{
MetaKmsPlane *kms_plane = l->data;
if (meta_kms_plane_get_plane_type (kms_plane) !=
META_KMS_PLANE_TYPE_PRIMARY)
continue;
if (!meta_kms_plane_is_usable_with (kms_plane, kms_crtc))
continue;
supported = TRUE;
if (!meta_kms_plane_is_format_supported (kms_plane, drm_format))
return FALSE;
}
return supported;
}
static gboolean
create_secondary_egl_config (MetaEgl *egl,
MetaRendererNativeGpuData *renderer_gpu_data,
@ -1652,11 +1682,9 @@ create_secondary_egl_config (MetaEgl *egl,
for (l = meta_gpu_get_crtcs (META_GPU (gpu_kms)); l; l = l->next)
{
MetaCrtcKms *crtc_kms = META_CRTC_KMS (l->data);
MetaKmsPlane *kms_plane =
meta_crtc_kms_get_assigned_primary_plane (crtc_kms);
if (!meta_kms_plane_is_format_supported (kms_plane,
gles3_formats[i]))
if (!all_primary_planes_support_format (crtc_kms,
gles3_formats[i]))
break;
}