brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MetaWindowActor: assert that we have plugin manager on simple effect

Browse Source 
It looks that there are some extensions that run a Mainloop on startup,
causing to dispatch a clutter paint before the compositor is even available.
In such scenario a MetaWindow could try to start a simple effect
using a compositor plugin which is not there yet.

Then in order to catch these bugs we can now assert that the expected
conditions are valid, so that gnome-shell will provide a dumpstack to
debug the real offending JS code.

https://bugzilla.gnome.org/show_bug.cgi?id=789223
This commit is contained in:
Marco Trevisan (Treviño) 2017-10-20 02:52:04 -05:00
parent 5fa8f78434
commit 91e3a0b3a9
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/compositor/meta-window-actor.c
View File

@ -1076,6 +1076,8 @@ start_simple_effect (MetaWindowActor *self,
gint *counter = NULL; gint *counter = NULL;
gboolean use_freeze_thaw = FALSE; gboolean use_freeze_thaw = FALSE;
g_assert (compositor->plugin_mgr != NULL);
switch (event) switch (event)
{ {
case META_PLUGIN_NONE: case META_PLUGIN_NONE: