brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

wayland: Reword comment

Browse Source 
This is no longer directly related to DBus messages, but our own event
queue. Change the wording and use CLUTTER_PRIORITY_EVENTS to make it
bolder, even though it's the same than G_PRIORITY_DEFAULT.

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1286
This commit is contained in:
Carlos Garnacho 2020-07-06 12:44:26 +02:00 committed by Robert Mader
parent 6f316345be
commit 8cc95e44f4
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/wayland/meta-wayland-text-input.c
View File

@ -156,20 +156,17 @@ meta_wayland_text_input_focus_defer_done (ClutterInputFocus *focus)
if (text_input->done_idle_id != 0) if (text_input->done_idle_id != 0)
return; return;
/* This operates on 3 principles: /* This operates on 2 principles:
* - GDBus uses G_PRIORITY_DEFAULT to put messages in the thread default main * - IM operations come as individual ClutterEvents
* context.
* - All relevant ClutterInputFocus methods are ultimately backed by
* DBus methods inside IBus.
* - We want to run .done after them all. The slightly lower * - We want to run .done after them all. The slightly lower
* G_PRIORITY_DEFAULT + 1 priority should ensure we at least group * CLUTTER_PRIORITY_EVENTS + 1 priority should ensure we at least group
* all messages seen so far. * all events seen so far.
* *
* FIXME: .done may be delayed indefinitely if there's a high enough * FIXME: .done may be delayed indefinitely if there's a high enough
* priority idle source in the main loop. It's unlikely that * priority idle source in the main loop. It's unlikely that
* recurring idles run at this high priority though. * recurring idles run at this high priority though.
*/ */
text_input->done_idle_id = g_idle_add_full (G_PRIORITY_DEFAULT + 1, text_input->done_idle_id = g_idle_add_full (CLUTTER_PRIORITY_EVENTS + 1,
done_idle_cb, focus, NULL); done_idle_cb, focus, NULL);
} }